Skip to content

Commit d316bec

Browse files
Potential fix for code scanning alert no. 121: LDAP query built from user-controlled sources
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
1 parent 6e3e6c5 commit d316bec

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

src/main/java/org/owasp/benchmark/testcode/Benchmark00694.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import javax.servlet.http.HttpServlet;
2424
import javax.servlet.http.HttpServletRequest;
2525
import javax.servlet.http.HttpServletResponse;
26+
import org.owasp.esapi.ESAPI;
2627

2728
@WebServlet(value = "/ldapi-00/Benchmark00694")
2829
public class Benchmark00694 extends HttpServlet {
@@ -54,7 +55,8 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
5455
String base = "ou=users,ou=system";
5556
javax.naming.directory.SearchControls sc = new javax.naming.directory.SearchControls();
5657
sc.setSearchScope(javax.naming.directory.SearchControls.SUBTREE_SCOPE);
57-
String filter = "(&(objectclass=person)(uid=" + bar + "))";
58+
String safeBar = ESAPI.encoder().encodeForLDAP(bar);
59+
String filter = "(&(objectclass=person)(uid=" + safeBar + "))";
5860
// System.out.println("Filter " + filter);
5961
boolean found = false;
6062
javax.naming.NamingEnumeration<javax.naming.directory.SearchResult> results =

0 commit comments

Comments
 (0)