Fix duplicate metrics registration in mysql datastore #2554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
authzedbot
added a commit
to authzed/cla
that referenced
this pull request
Sep 9, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
==========================================
- Coverage 77.77% 77.77% -0.00%
==========================================
Files 440 440
Lines 53689 53690 +1
==========================================
- Hits 41751 41750 -1
- Misses 9344 9346 +2
Partials 2594 2594 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leonnicolas
force-pushed
the
fix-metrics-collector-for-mysql-datastore
branch
from
fdc53e5 to
7a35b83
Compare
When using a replica with the mysql datastore, we register the same metrics again and again. This commit ignores AlreadyRegisteredError when registering our custom metrics and adds a `db_name` label similar to the postgres instrumentation. Additionally, it updates the tests for multi instance creation in a way that we don't create 2 connections with the same index. Otherwise we would get another registration error when registering the sql collector `sqlstats`. fixes: authzed#2518 Signed-off-by: leonnicolas <[email protected]> Override the default Prometheus registry in tests again Some tests were failing when previous test cases registered their metrics with the default Prometheus registry. Signed-off-by: leonnicolas <[email protected]>
In order to increase the coverage of the patch, I added the following tests: - connection metrics can't be registered - duplicate db names are used to create the datastore Signed-off-by: leonnicolas <[email protected]>
leonnicolas
force-pushed
the
fix-metrics-collector-for-mysql-datastore
branch
from
7a35b83 to
8b2afbf
Compare
Author
|
I hope I could increase the patch coverage with my last changes and fix the commit message format |
miparnisari
added a commit
that referenced
this pull request
Nov 15, 2025
Contributor
|
Hi @leonnicolas, I sent this #2707 😅 I am sorry that I didn't see this before. I am going to close it, but thanks for spending time looking at it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a replica with the mysql datastore, we register the
same metrics again and again.
This commit ignores AlreadyRegisteredError when registering our
custom metrics and adds a
db_namelabel similar to the postgresinstrumentation.
Additionally, it updates the tests for multi instance creation in a way that we
don't create 2 connections with the same index. Otherwise we would
get another registration error when registering the sql collector
sqlstats.fixes: #2518
Signed-off-by: leonnicolas [email protected]