Skip to content

Conversation

@miparnisari
Copy link
Contributor

contextRemoveCmd := &cobra.Command{
Use: "remove <system>",
Short: "Removes a context",
Use: "remove <name>",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI when you list, you get a NAME column, not a SYSTEM

$ zed context list
 CURRENT  NAME          ENDPOINT                                 TOKEN                  TLS CERT 
          local         localhost:50051                          <redacted>             system   
    ✓     example       localhost:50051                          <redacted>             insecure 

@miparnisari miparnisari marked this pull request as ready for review October 31, 2025 23:29
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 10.71429% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.72%. Comparing base (7ed5ab0) to head (d26cd98).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
internal/commands/relationship.go 0.00% 12 Missing ⚠️
internal/commands/watch.go 0.00% 8 Missing ⚠️
internal/commands/permission.go 0.00% 4 Missing ⚠️
internal/storage/secrets.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   39.28%   41.72%   +2.44%     
==========================================
  Files          37       37              
  Lines        5448     4760     -688     
==========================================
- Hits         2140     1986     -154     
+ Misses       3063     2517     -546     
- Partials      245      257      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tstirrat15
tstirrat15 previously approved these changes Oct 31, 2025
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit 022f31a into main Nov 1, 2025
10 checks passed
@miparnisari miparnisari deleted the add-examples branch November 1, 2025 02:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants