build(deps): bump github.com/ccoveille/go-safecast to v2.0.0

[ccoVeille]

Description

I'm the owner of https://github.com/ccoVeille/go-safecast

I noticed your CI was broken because of my recent changes to add deprecation warning to some methods.

• chore: add deprecation notice to all ToIntXX and ToUIntXX functions ccoVeille/go-safecast#122

Note: I made some slight changes, as I update the returned value in the v2 of my lib

• v2: introduce breaking changes ccoVeille/go-safecast#120

So I added check on the error to use zero as a fall back to replicate what would do the v1.

Working on your PR helped me to figure things, such as there is a real need for me to support uintptr

• check what we can do with uintptr ccoVeille/go-safecast#17

See

zed/internal/cmd/schema.go

Line 226 in 022f31a

stdInFd, err := safecast.ToInt(uint(os.Stdin.Fd()))

Testing

Launched golangci-lint locally.

Please note, I checked that the gosec issue false positive is still there.

References

Related #573: fix the issue with linting reporting go-safecast deprecation warning of ToInt

• build(deps): bump the go-mod group with 12 updates #573

Related to

• Help people using my lib to migrate to v1.8.X / v2.x.x ccoVeille/go-safecast#126
• chore: add deprecation notice to all ToIntXX and ToUIntXX functions ccoVeille/go-safecast#122
• build(deps): migrate to github.com/ccoveille/go-safecast v2 spicedb#2685

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[tstirrat15]

Thank you for putting this up! We've already put through a couple of update PRs in our other repos - I like the API changes, and it only broke CI because we're pretty aggressive about deprecation warnings. It would have thrown at some point or another.

And yeah I don't mind having a manual workaround for uintptr - the particular functionality is a weird edge case in the golang stdlib and I don't feel like your lib needs to handle it if it'd be too far out of the normal codepath.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.68%. Comparing base (7ed5ab0) to head (069dfe9).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/cmd/validate.go	33.33%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   39.28%   41.68%   +2.40%     
==========================================
  Files          37       37              
  Lines        5448     4764     -684     
==========================================
- Hits         2140     1986     -154     
+ Misses       3063     2519     -544     
- Partials      245      259      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ccoVeille]

I have updated the PR now I have published the v2 of my lib

https://github.com/ccoVeille/go-safecast/releases/tag/v2.0.0

It natively supports uintptr so I removed the int conversion, my lib now handles it

[tstirrat15]

Thank you for putting this through!