Rails 8.2 deprecates ActiveSupport::Configurable which is used by Marksmith

[gee-forr]

Hey there,

A wild deprecation warning has appeared.

Rails 8.1 has started issuing deprecation warnings for usage of ActiveSupport::Configurable. It is being deprecated with no replacement.

Marksmith uses ActiveSupport::Configurable as part of its configuration class

Repro steps

• Use Rails 8.1
• Use Marksmith 0.4.7
• Run a rails command, e.g. rails routes
• See deprecation warning:

DEPRECATION WARNING: ActiveSupport::Configurable is deprecated without replacement, and will be removed in Rails 8.2.

You can emulate the previous behavior with `class_attribute`.

System configuration

• Avo version: 3.52.x (using marksmith behind the scenes)
• Rails version: 8.1.0
  *Ruby version: 3.4.7

Urgency

• Low urgency (It can wait. I just wanted you to know about it.)

[adrianthedev]

Darn it...

In Avo we have our own which is modeled after shopify_app's.
I was kinda happy to switch Avo's to ActiveSupport::Configurable and have the same thing that Rails has.

Any suggestions?
I'm inclined to duplicate ActiveSupport::Configurable (pull the behaviour in the current repo) and continue using like that.
What do you think/suggest?

Thanks for the nudge.

[gee-forr]

I was kinda happy to switch Avo's to ActiveSupport::Configurable and have the same thing that Rails has.

Any suggestions? I'm inclined to duplicate ActiveSupport::Configurable (pull the behaviour in the current repo) and continue using like that. What do you think/suggest?

I don't really have a horse in this race, other than getting the deprecation addressed.

That being said, Marksmith has 3 configurable values from what I can tell. In my opinion, duplicating an entire library dedicated to simplifying gem config -- and maintaining it for the rest of its life -- is overkill in this situation.

For Avo itself having something that makes config more ergonomic, makes way more sense. Avo manages ~60 configurable attrs, so porting AS::Configurable over into an appropriate Avo namespaced class is a sensible approach.

[jschwindt]

My PR resolved this issue, and the solution is very straightforward.