Add aws sigv4a support #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onno-vos-dev
approved these changes
Mar 13, 2025
| -include("aws_sigv4_internal.hrl"). | ||
|
|
||
| -spec derive(aws_sigv4_internal:credentials()) -> {ok, binary()} | {error, any()}. | ||
| derive(Credentials) -> |
Member
There was a problem hiding this comment.
This function is why I love Erlang ❤️ So much easier to follow than the Go-code IMHO 😄
Member
|
Amazing work @mikpe ❤️ |
Collaborator
Author
|
I'll start on the cleanups next. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for AWS' Asymmetric Signature Version 4, aka SigV4a. The implementation is closely modelled after AWS' Go implementation (https://github.com/aws/smithy-go/tree/main/aws-http-auth). All relevant test cases have been ported over as well.
Following the structure of the Go original does lead to some code duplication with the existing plain SigV4 Erlang code, but that can be addressed by followup refactoring. I didn't want to tear that code apart right now.