Skip to content

Commit 1fcb7b6

Browse files
authored
Split acks when multiple are received in a single response (#276)
* Split acks when multiple are received in a single response * Rename the variable
1 parent e67d9a8 commit 1fcb7b6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/test/java/com/amazonaws/kinesisvideo/client/PutMediaClientErrorTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ public class PutMediaClientErrorTest {
6767
private static final Logger log = LogManager.getLogger(PutMediaClientErrorTest.class);
6868

6969
private static final int TIMEOUT_SECONDS = 20;
70+
private static final String DELIMITER_WITHOUT_LF = "\n\r\n";
7071
private static final String DELIMITER = "\r\n\r\n";
7172
private static final String END_OF_STREAM_MSG = "0" + DELIMITER;
7273
private static final String PUT_MEDIA_POSTFIX = "/putMedia";
@@ -205,7 +206,7 @@ public void accept(final InputStream acks) {
205206

206207
if (!response.isEmpty()) {
207208
// There could more than one ack inside of this message
208-
Arrays.stream(response.split(DELIMITER))
209+
Arrays.stream(response.split(DELIMITER_WITHOUT_LF))
209210
.peek(ackStr -> log.info("Received ack: {}", response))
210211
.forEach(acksReceived::add);
211212
}

src/test/java/com/amazonaws/kinesisvideo/client/PutMediaClientWithFilesTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ public class PutMediaClientWithFilesTest {
7575

7676
private static final Logger log = LogManager.getLogger(PutMediaClientWithFilesTest.class);
7777

78+
private static final String DELIMITER_WITHOUT_LF = "\n\r\n";
7879
private static final String DELIMITER = "\r\n\r\n";
7980
private static final String END_OF_STREAM_MSG = "0" + DELIMITER;
8081
private static final String PUT_MEDIA_POSTFIX = "/putMedia";
@@ -263,7 +264,7 @@ public void accept(final InputStream acks) {
263264

264265
if (!response.isEmpty()) {
265266
// There could more than one ack inside of this message
266-
Arrays.stream(response.split(DELIMITER))
267+
Arrays.stream(response.split(DELIMITER_WITHOUT_LF))
267268
.peek(ackStr -> log.info("Received ack: {}", response))
268269
.forEach(acksReceived::add);
269270
}

0 commit comments

Comments
 (0)