generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(samples/cloudwatch-applicationsignals-mcp): add ecs samples for enablement testing #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...dwatch-applicationsignals-mcp/get-enablement-guide-samples/infrastructure/ecs/cdk/bin/cdk.ts
Show resolved
Hide resolved
yiyuan-he
reviewed
Nov 12, 2025
...tionsignals-mcp/get-enablement-guide-samples/infrastructure/ecs/cdk/config/python-flask.json
Show resolved
Hide resolved
yiyuan-he
reviewed
Nov 12, 2025
...dwatch-applicationsignals-mcp/get-enablement-guide-samples/infrastructure/ecs/cdk/bin/cdk.ts
Outdated
Show resolved
Hide resolved
yiyuan-he
approved these changes
Nov 12, 2025
Contributor
yiyuan-he
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1727 +/- ##
==========================================
- Coverage 90.26% 90.23% -0.03%
==========================================
Files 781 739 -42
Lines 59912 58108 -1804
Branches 9718 9570 -148
==========================================
- Hits 54077 52434 -1643
+ Misses 3646 3504 -142
+ Partials 2189 2170 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
vastin
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Adding ECS samples for Python, Node.js and Java for APM enablement tool testing infra.
Changes
This PR adds ECS baseline applications for testing APM enablement via the get_enablement_guide MCP tool.
User experience
N/A
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.