Skip to content

Commit d17967b

Browse files
authored
fix(api-connection): fix options proxy query filter type error with tanstack query v5.74.3 (#149)
TanStack Query v5.74.3 removed the data and error type parameters from the QueryFilters type. We therefore do not include them in the generated code. Fixes #147
1 parent 2bcae34 commit d17967b

File tree

5 files changed

+26
-30
lines changed

5 files changed

+26
-30
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"@phenomnomnominal/tsquery": "6.1.3",
3636
"@quantco/pnpm-licenses": "^2.2.1",
3737
"@tailwindcss/vite": "^4.0.16",
38-
"@tanstack/react-query": "^5.69.0",
38+
"@tanstack/react-query": "^5.74.3",
3939
"@testing-library/react": "^16.2.0",
4040
"@ts-morph/bootstrap": "^0.26.1",
4141
"@types/fs-extra": "^11.0.4",

packages/nx-plugin/src/open-api/ts-hooks/__snapshots__/generator.spec.tsx.snap

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ export class TestApiOptionsProxy {
9898
...options,
9999
};
100100
}
101-
private _getTestQueryFilter(
102-
filter?: QueryFilters<GetTest200Response, GetTestError>,
103-
): QueryFilters<GetTest200Response, GetTestError> {
101+
private _getTestQueryFilter(filter?: QueryFilters): QueryFilters {
104102
return {
105103
queryKey: this._getTestQueryKey(),
106104
...filter,
@@ -173,8 +171,8 @@ export class TestApiOptionsProxy {
173171
}
174172
private _getItemsQueryFilter(
175173
input: GetItemsRequest,
176-
filter?: QueryFilters<GetItems200Response, GetItemsError>,
177-
): QueryFilters<GetItems200Response, GetItemsError> {
174+
filter?: QueryFilters,
175+
): QueryFilters {
178176
return {
179177
queryKey: this._getItemsQueryKey(input),
180178
...filter,
@@ -338,8 +336,8 @@ export class TestApiOptionsProxy {
338336
}
339337
private _searchDataQueryFilter(
340338
input: SearchDataRequest,
341-
filter?: QueryFilters<SearchData200Response, SearchDataError>,
342-
): QueryFilters<SearchData200Response, SearchDataError> {
339+
filter?: QueryFilters,
340+
): QueryFilters {
343341
return {
344342
queryKey: this._searchDataQueryKey(input),
345343
...filter,
@@ -412,8 +410,8 @@ export class TestApiOptionsProxy {
412410
}
413411
private _getItemsQueryFilter(
414412
input: GetItemsRequest,
415-
filter?: QueryFilters<GetItems200Response, GetItemsError>,
416-
): QueryFilters<GetItems200Response, GetItemsError> {
413+
filter?: QueryFilters,
414+
): QueryFilters {
417415
return {
418416
queryKey: this._getItemsQueryKey(input),
419417
...filter,
@@ -529,8 +527,8 @@ export class TestApiOptionsProxy {
529527
}
530528
private _listRecordsQueryFilter(
531529
input: ListRecordsRequest,
532-
filter?: QueryFilters<ListRecords200Response, ListRecordsError>,
533-
): QueryFilters<ListRecords200Response, ListRecordsError> {
530+
filter?: QueryFilters,
531+
): QueryFilters {
534532
return {
535533
queryKey: this._listRecordsQueryKey(input),
536534
...filter,
@@ -687,9 +685,7 @@ export class TestApiOptionsProxy {
687685
...options,
688686
};
689687
}
690-
private _getErrorQueryFilter(
691-
filter?: QueryFilters<GetError200Response, GetErrorError>,
692-
): QueryFilters<GetError200Response, GetErrorError> {
688+
private _getErrorQueryFilter(filter?: QueryFilters): QueryFilters {
693689
return {
694690
queryKey: this._getErrorQueryKey(),
695691
...filter,
@@ -809,8 +805,8 @@ export class TestApiOptionsProxy {
809805
}
810806
private _streamLogsQueryFilter(
811807
input: StreamLogsRequest,
812-
filter?: QueryFilters<StreamLogs200Response[], StreamLogsError>,
813-
): QueryFilters<StreamLogs200Response[], StreamLogsError> {
808+
filter?: QueryFilters,
809+
): QueryFilters {
814810
return {
815811
queryKey: this._streamLogsQueryKey(input),
816812
...filter,
@@ -1074,8 +1070,8 @@ export class TestApiOptionsProxy {
10741070
}
10751071
private _streamEventsQueryFilter(
10761072
input: StreamEventsRequest,
1077-
filter?: QueryFilters<StreamEvents200Response[], StreamEventsError>,
1078-
): QueryFilters<StreamEvents200Response[], StreamEventsError> {
1073+
filter?: QueryFilters,
1074+
): QueryFilters {
10791075
return {
10801076
queryKey: this._streamEventsQueryKey(input),
10811077
...filter,

packages/nx-plugin/src/open-api/ts-hooks/files/options-proxy.gen.ts.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class <%- className %>OptionsProxy {
133133
...options,
134134
};
135135
}
136-
private _<%- op.uniqueName %>QueryFilter(<%- input %><% if (op.parameters.length > 0) { %>, <% } %>filter?: QueryFilters<<%- queryResultType %>, <%- errorType %>>): QueryFilters<<%- queryResultType %>, <%- errorType %>> {
136+
private _<%- op.uniqueName %>QueryFilter(<%- input %><% if (op.parameters.length > 0) { %>, <% } %>filter?: QueryFilters): QueryFilters {
137137
return {
138138
queryKey: this._<%- op.uniqueName %>QueryKey(<% if (op.parameters.length > 0) { %>input<% } %>),
139139
...filter,

packages/nx-plugin/src/utils/versions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export const VERSIONS = {
1717
'@cloudscape-design/board-components': '^3.0.94',
1818
'@cloudscape-design/components': '^3.0.928',
1919
'@cloudscape-design/global-styles': '^1.0.38',
20-
'@tanstack/react-query': '5.74.2', // TODO: https://github.com/awslabs/nx-plugin-for-aws/issues/147
20+
'@tanstack/react-query': '^5.74.3',
2121
'@trpc/tanstack-react-query': '11.0.0',
2222
'@trpc/client': '11.0.0',
2323
'@trpc/server': '11.0.0',

pnpm-lock.yaml

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)