Merge pull request #139 from arkivanov/remove-Lifecycle-Callbacks-method-bodies

Remove Lifecycle.Callbacks method bodies

Author: arkivanov

mvikotlin-extensions-androidx/src/androidMain/kotlin/com/arkivanov/mvikotlin/extensions/androidx/instancekeeper/InstanceKeeperViewModel.kt

@@ -2,8 +2,8 @@ package com.arkivanov.mvikotlin.extensions.androidx.instancekeeper
 
 import androidx.lifecycle.ViewModel
 import com.arkivanov.mvikotlin.core.instancekeeper.ExperimentalInstanceKeeperApi
-import com.arkivanov.mvikotlin.core.instancekeeper.InstanceKeeperProvider
 import com.arkivanov.mvikotlin.core.instancekeeper.InstanceContainer
+import com.arkivanov.mvikotlin.core.instancekeeper.InstanceKeeperProvider
 import com.arkivanov.mvikotlin.core.lifecycle.Lifecycle
 import com.arkivanov.mvikotlin.core.lifecycle.LifecycleRegistry
 import com.arkivanov.mvikotlin.core.lifecycle.destroy

mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/lifecycle/DefaultLifecycleCallbacks.kt

@@ -0,0 +1,22 @@
+package com.arkivanov.mvikotlin.core.lifecycle
+
+interface DefaultLifecycleCallbacks : Lifecycle.Callbacks {
+
+    override fun onCreate() {
+    }
+
+    override fun onStart() {
+    }
+
+    override fun onResume() {
+    }
+
+    override fun onPause() {
+    }
+
+    override fun onStop() {
+    }
+
+    override fun onDestroy() {
+    }
+}

mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/lifecycle/Lifecycle.kt

@@ -59,27 +59,21 @@ interface Lifecycle {
      */
     interface Callbacks {
         @MainThread
-        fun onCreate() {
-        }
+        fun onCreate()
 
         @MainThread
-        fun onStart() {
-        }
+        fun onStart()
 
         @MainThread
-        fun onResume() {
-        }
+        fun onResume()
 
         @MainThread
-        fun onPause() {
-        }
+        fun onPause()
 
         @MainThread
-        fun onStop() {
-        }
+        fun onStop()
 
         @MainThread
-        fun onDestroy() {
-        }
+        fun onDestroy()
     }
 }

mvikotlin/src/commonMain/kotlin/com/arkivanov/mvikotlin/core/lifecycle/LifecycleExt.kt

@@ -9,7 +9,7 @@ package com.arkivanov.mvikotlin.core.lifecycle
  */
 inline fun Lifecycle.doOnDestroy(crossinline onDestroy: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onDestroy() {
                 onDestroy.invoke()
             }
@@ -27,7 +27,7 @@ inline fun Lifecycle.doOnDestroy(crossinline onDestroy: () -> Unit) {
  */
 inline fun Lifecycle.doOnCreateDestroy(crossinline onCreate: () -> Unit, crossinline onDestroy: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onCreate() {
                 onCreate.invoke()
             }
@@ -48,7 +48,7 @@ inline fun Lifecycle.doOnCreateDestroy(crossinline onCreate: () -> Unit, crossin
  */
 inline fun Lifecycle.doOnStop(crossinline onStop: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onStop() {
                 onStop.invoke()
             }
@@ -66,7 +66,7 @@ inline fun Lifecycle.doOnStop(crossinline onStop: () -> Unit) {
  */
 inline fun Lifecycle.doOnStartStop(crossinline onStart: () -> Unit, crossinline onStop: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onStart() {
                 onStart.invoke()
             }
@@ -87,7 +87,7 @@ inline fun Lifecycle.doOnStartStop(crossinline onStart: () -> Unit, crossinline
  */
 inline fun Lifecycle.doOnPause(crossinline onPause: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onPause() {
                 onPause.invoke()
             }
@@ -105,7 +105,7 @@ inline fun Lifecycle.doOnPause(crossinline onPause: () -> Unit) {
  */
 inline fun Lifecycle.doOnResumePause(crossinline onResume: () -> Unit, crossinline onPause: () -> Unit) {
     subscribe(
-        object : Lifecycle.Callbacks {
+        object : DefaultLifecycleCallbacks {
             override fun onResume() {
                 onResume.invoke()
             }