Add legacy tests, correct case leading to "parseInt('123-')"

Author: Bryan

lib/utilities/parse/price.js

@@ -91,17 +91,27 @@ module.exports = (() => {
 
 			const fractionDigits = unitCodeItem.getFractionDigits(specialFractions);
 
-			let integerCharacters = value.substring(0, value.length - fractionDigits - fractionSeparator.length);
-			let fractionCharacters = value.slice(-fractionDigits);
+			let integerCharacters;
+			let fractionCharacters;
 
-			if (integerCharacters === '') {
-				integerCharacters = '0';
+			if (fractionSeparator.length === 1) {
+				const characterGroups = value.split(fractionSeparator);
+
+				integerCharacters = characterGroups[0];
+				fractionCharacters = characterGroups[1];
+			} else {
+				integerCharacters = value.substring(0, value.length - fractionDigits - fractionSeparator.length);
+				fractionCharacters = value.slice(-fractionDigits);
 			}
 
 			if (fractionCharacters.length !== fractionDigits) {
 				return Number.NaN;
 			}
 
+			if (integerCharacters === '') {
+				integerCharacters = '0';
+			}
+
 			const integerPart = parseInt(integerCharacters);
 			const fractionPart = parseInt(fractionCharacters);
 

test/specs/utilities/parse/priceSpec.js

@@ -456,4 +456,28 @@ describe('when valid prices are parsed', () => {
 			});
 		});
 	});
+
+	describe('with ad hoc settings from previous unit tests', () => {
+		it('parses "125-5" as 125.625 (with unit code 2)', () => {
+			expect(parsePrice('125-5', '2')).toEqual(125.625);
+		});
+
+		it('parses "-125-5" as -125.625 (with unit code 2)', () => {
+			expect(parsePrice('-125-5', '2')).toEqual(-125.625);
+		});
+
+		it('parses "125-240" as 125.75 (with unit code 5, using special fractions)', () => {
+			expect(parsePrice('125-240', '5', '-', true)).toEqual(125.75);
+		});
+
+		it('parses "-125-240" as -125.75 (with unit code 5, using special fractions)', () => {
+			expect(parsePrice('-125-240', '5', '-', true)).toEqual(-125.75);
+		});
+	});
+
+	describe('with insufficient data to infer correct settings', () => {
+		it('parses "125-240" as Number.NaN (with unit code 5 where "special fractions" cannot be inferred)', () => {
+			expect(parsePrice('125-240', '5')).toEqual(Number.NaN);
+		});
+	});
 });