refactor(search): specific method names

Author: bartholomej

src/helpers/search.helper.ts

@@ -6,42 +6,42 @@ import { addProtocol, parseColor, parseIdFromUrl } from './global.helper';
 
 type Creator = 'Režie:' | 'Hrají:';
 
-export const getType = (el: HTMLElement): CSFDFilmTypes => {
+export const getSearchType = (el: HTMLElement): CSFDFilmTypes => {
   const type = el.querySelectorAll('.film-title-info .info')[1];
   return (type?.innerText.replace(/[{()}]/g, '') || 'film') as CSFDFilmTypes;
 };
 
-export const getTitle = (el: HTMLElement): string => {
+export const getSearchTitle = (el: HTMLElement): string => {
   return el.querySelector('.film-title-name').text;
 };
 
-export const getYear = (el: HTMLElement): number => {
+export const getSearchYear = (el: HTMLElement): number => {
   return +el.querySelectorAll('.film-title-info .info')[0]?.innerText.replace(/[{()}]/g, '');
 };
 
-export const getUrl = (el: HTMLElement): string => {
+export const getSearchUrl = (el: HTMLElement): string => {
   return el.querySelector('.film-title-name').attributes.href;
 };
 
-export const getColorRating = (el: HTMLElement): CSFDColorRating => {
+export const getSearchColorRating = (el: HTMLElement): CSFDColorRating => {
   return parseColor(
     el.querySelector('.article-header i.icon').classNames.split(' ').pop() as Colors
   );
 };
 
-export const getPoster = (el: HTMLElement): string => {
+export const getSearchPoster = (el: HTMLElement): string => {
   const image = el.querySelector('img').attributes.src;
   return addProtocol(image);
 };
 
-export const getOrigins = (el: HTMLElement): string[] => {
+export const getSearchOrigins = (el: HTMLElement): string[] => {
   const originsRaw = el.querySelector('.article-content p .info')?.text;
   if (!originsRaw) return [];
   const originsAll = originsRaw?.split(', ')?.[0];
   return originsAll?.split('/').map((country) => country.trim());
 };
 
-export const parsePeople = (el: HTMLElement, type: 'directors' | 'actors'): CSFDCreator[] => {
+export const parseSearchPeople = (el: HTMLElement, type: 'directors' | 'actors'): CSFDCreator[] => {
   let who: Creator;
   if (type === 'directors') who = 'Režie:';
   if (type === 'actors') who = 'Hrají:';

src/services/search.service.ts

@@ -3,14 +3,14 @@ import { fetchPage } from '../fetchers';
 import { parseIdFromUrl } from '../helpers/global.helper';
 import { getAvatar, getUser, getUserRealName, getUserUrl } from '../helpers/search-user.helper';
 import {
-  getColorRating,
-  getOrigins,
-  getPoster,
-  getTitle,
-  getType,
-  getUrl,
-  getYear,
-  parsePeople
+  getSearchColorRating,
+  getSearchOrigins,
+  getSearchPoster,
+  getSearchTitle,
+  getSearchType,
+  getSearchUrl,
+  getSearchYear,
+  parseSearchPeople
 } from '../helpers/search.helper';
 import { CSFDSearch, CSFDSearchMovie, CSFDSearchUser } from '../interfaces/search.interface';
 import { searchUrl } from '../vars';
@@ -38,20 +38,20 @@ export class SearchScraper {
     const tvSeries: CSFDSearchMovie[] = [];
 
     moviesNode.forEach((m) => {
-      const url = getUrl(m);
+      const url = getSearchUrl(m);
 
       const movie: CSFDSearchMovie = {
         id: parseIdFromUrl(url),
-        title: getTitle(m),
-        year: getYear(m),
+        title: getSearchTitle(m),
+        year: getSearchYear(m),
         url: `https://www.csfd.cz${url}`,
-        type: getType(m),
-        colorRating: getColorRating(m),
-        poster: getPoster(m),
-        origins: getOrigins(m),
+        type: getSearchType(m),
+        colorRating: getSearchColorRating(m),
+        poster: getSearchPoster(m),
+        origins: getSearchOrigins(m),
         creators: {
-          directors: parsePeople(m, 'directors'),
-          actors: parsePeople(m, 'actors')
+          directors: parseSearchPeople(m, 'directors'),
+          actors: parseSearchPeople(m, 'actors')
         }
       };
       movies.push(movie);
@@ -71,20 +71,20 @@ export class SearchScraper {
     });
 
     tvSeriesNode.forEach((m) => {
-      const url = getUrl(m);
+      const url = getSearchUrl(m);
 
       const user: CSFDSearchMovie = {
         id: parseIdFromUrl(url),
-        title: getTitle(m),
-        year: getYear(m),
+        title: getSearchTitle(m),
+        year: getSearchYear(m),
         url: `https://www.csfd.cz${url}`,
-        type: getType(m),
-        colorRating: getColorRating(m),
-        poster: getPoster(m),
-        origins: getOrigins(m),
+        type: getSearchType(m),
+        colorRating: getSearchColorRating(m),
+        poster: getSearchPoster(m),
+        origins: getSearchOrigins(m),
         creators: {
-          directors: parsePeople(m, 'directors'),
-          actors: parsePeople(m, 'actors')
+          directors: parseSearchPeople(m, 'directors'),
+          actors: parseSearchPeople(m, 'actors')
         }
       };
       tvSeries.push(user);

tests/creator.test.ts

@@ -146,7 +146,7 @@ describe('Composer info', () => {
 
   test('Bio', () => {
     const creator = getCreatorBio(asideNodeComposer);
-    expect(creator).toEqual<string>(null);
+    expect(creator).toEqual<string>(null as any);
   });
 
   test('Photo', () => {