Skip to content

Commit d0de469

Browse files
authored
Merge pull request #139 from basho/develo-3.0-fix-eqc-macros
fix eqc macros
2 parents a7fae63 + 2e6a001 commit d0de469

11 files changed

+16
-15
lines changed

Makefile

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.PHONY: compile rel cover test dialyzer
1+
.PHONY: compile rel cover test dialyzer eqc
22
REBAR=./rebar3
33

44
compile:
@@ -19,4 +19,8 @@ dialyzer:
1919
xref:
2020
$(REBAR) xref
2121

22+
eqc:
23+
$(REBAR) eqc
24+
25+
2226
check: test dialyzer xref

src/riak_dt_emcntr.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ to_version(_Version, Cntr) ->
256256
%% ===================================================================
257257
%% EUnit tests
258258
%% ===================================================================
259-
-ifdef(TEST).
260259

261260
-ifdef(EQC).
262261
%% EQC generator
@@ -304,6 +303,7 @@ eqc_state_value(S) ->
304303
S.
305304
-endif.
306305

306+
-ifdef(TEST).
307307
new_test() ->
308308
?assertEqual(0, value(new())).
309309

src/riak_dt_enable_flag.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ flag_or(off, off) ->
122122
%% ===================================================================
123123
%% EUnit tests
124124
%% ===================================================================
125-
-ifdef(TEST).
126125

127126
-ifdef(EQC).
128127
prop_crdt_converge() ->
@@ -144,6 +143,7 @@ eqc_state_value(S) ->
144143
S.
145144
-endif.
146145

146+
-ifdef(TEST).
147147
new_test() ->
148148
?assertEqual(off, new()).
149149

src/riak_dt_gcounter.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ to_version(_Version, C) ->
159159
%% ===================================================================
160160
%% EUnit tests
161161
%% ===================================================================
162-
-ifdef(TEST).
163162

164163
-ifdef(EQC).
165164
prop_crdt_converge() ->
@@ -197,6 +196,7 @@ eqc_state_value(S) ->
197196
S.
198197
-endif.
199198

199+
-ifdef(TEST).
200200
new_test() ->
201201
?assertEqual([], new()).
202202

src/riak_dt_gset.erl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ to_binary_test() ->
179179
GSet = update({add, <<"foo">>}, undefined_actor, riak_dt_gset:new()),
180180
Bin = riak_dt_gset:to_binary(GSet),
181181
?assertMatch( <<82:8/integer, ?V2_VERS:8/integer, _/binary>> , Bin).
182+
-endif.
182183

183184
-ifdef(EQC).
184185
prop_crdt_converge() ->
@@ -216,5 +217,3 @@ eqc_state_value(Dict) ->
216217
sets:to_list(S).
217218

218219
-endif.
219-
220-
-endif.

src/riak_dt_lwwreg.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ to_version(_Version, LWW) ->
164164
%% ===================================================================
165165
%% EUnit tests
166166
%% ===================================================================
167-
-ifdef(TEST).
168167

169168
-ifdef(EQC).
170169
prop_crdt_converge() ->
@@ -204,6 +203,7 @@ eqc_state_value({Val, _TS}) ->
204203
Val.
205204
-endif.
206205

206+
-ifdef(TEST).
207207
new_test() ->
208208
?assertEqual({<<>>, 0}, new()).
209209

src/riak_dt_od_flag.erl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,6 @@ to_version(_Version, Flag) ->
209209
%% ===================================================================
210210
%% EUnit tests
211211
%% ===================================================================
212-
-ifdef(TEST).
213212

214213
-ifdef(EQC).
215214
prop_crdt_converge() ->
@@ -256,6 +255,8 @@ eqc_state_value(Dict) ->
256255
orddict:fold(fun(_K, V, Acc) -> V or Acc end, false, Dict).
257256
-endif.
258257

258+
-ifdef(TEST).
259+
259260
disable_test() ->
260261
{ok, A} = update(enable, a, new()),
261262
{ok, B} = update(enable, b, new()),

src/riak_dt_oe_flag.erl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ to_version(_Version, Flag) ->
151151
%% ===================================================================
152152
%% EUnit tests
153153
%% ===================================================================
154-
-ifdef(TEST).
155154

156155
-ifdef(EQC).
157156
prop_crdt_converge() ->
@@ -197,6 +196,7 @@ eqc_state_value(Dict) ->
197196
end, true, Dict).
198197
-endif.
199198

199+
-ifdef(TEST).
200200
new_test() ->
201201
?assertEqual(true, value(new())).
202202

src/riak_dt_orset.erl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ stat_test() ->
277277
?assertEqual(1, stat(adds_count, Set4)),
278278
?assertEqual(2, stat(removes_count, Set4)),
279279
?assertEqual(67, stat(waste_pct, Set4)).
280+
-endif.
280281

281282
-ifdef(EQC).
282283
prop_crdt_converge() ->
@@ -374,5 +375,3 @@ eqc_state_value({_Cnt, Dict}) ->
374375
lists:usort(Values).
375376

376377
-endif.
377-
378-
-endif.

src/riak_dt_orswot.erl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,7 @@ batch_order_test() ->
620620
{ok, Set4} = update({remove, <<"baz">>}, a, Set),
621621
{ok, Set5} = update({add, <<"baz">>}, a, Set4),
622622
?assertEqual([<<"bar">>, <<"baz">>], value(Set5)).
623+
-endif.
623624

624625
-ifdef(EQC).
625626
prop_crdt_converge() ->
@@ -751,5 +752,3 @@ is_sub_bag2([Elem | Rest], SuperBag) ->
751752
end.
752753

753754
-endif.
754-
755-
-endif.

0 commit comments

Comments
 (0)