Add some tests for DatabaseCrudController

Author: jmsche

src/Controller/Admin/DatabaseCrudController.php

@@ -72,6 +72,7 @@ public function createIndexQueryBuilder(SearchDto $searchDto, EntityDto $entityD
     public function launchBackupAction(AdminContext $context): Response
     {
         $database = $context->getEntity()->getInstance();
+        $this->denyAccessUnlessGranted(DatabaseVoter::CAN_SHOW_DATABASE, $database);
 
         try {
             $this->backupService->backup($database, Backup::CONTEXT_MANUAL);
@@ -89,6 +90,7 @@ public function showDatabaseBackupsAction(AdminContext $context): Response
     {
         /** @var Database $database */
         $database = $context->getEntity()->getInstance();
+        $this->denyAccessUnlessGranted(DatabaseVoter::CAN_SHOW_DATABASE, $database);
 
         $url = $this->adminUrlGenerator->setController(BackupCrudController::class)
             ->setAction(Action::INDEX)
@@ -115,6 +117,8 @@ public function configureActions(Actions $actions): Actions
         return $actions
             ->add(Crud::PAGE_INDEX, $launchBackupAction)
             ->add(Crud::PAGE_INDEX, $showDatabaseBackupsAction)
+            ->setPermission(Action::DELETE, DatabaseVoter::CAN_SHOW_DATABASE)
+            ->setPermission(Action::EDIT, DatabaseVoter::CAN_SHOW_DATABASE)
             ->setPermission('launchBackup', DatabaseVoter::CAN_SHOW_DATABASE)
             ->setPermission('showDatabaseBackups', DatabaseVoter::CAN_SHOW_DATABASE)
             ->remove(Crud::PAGE_NEW, Action::SAVE_AND_ADD_ANOTHER)

tests/Controller/Admin/DatabaseCrudControllerTest.php

@@ -8,6 +8,50 @@
 
 final class DatabaseCrudControllerTest extends AbstractCrudControllerTest
 {
+    public function testEdit(): void
+    {
+        $url = $this->getActionUrl('edit', 1);
+
+        self::$client->request('GET', $url);
+        self::assertResponseRedirects('/');
+
+        $this->loginAsAdmin();
+        self::$client->request('GET', $url);
+        self::assertResponseStatusCodeSame(403);
+
+        $this->loginAsUser();
+        self::$client->request('GET', $url);
+        self::assertResponseIsSuccessful();
+    }
+
+    public function testShowDatabaseBackupsAction(): void
+    {
+        $url = $this->getActionUrl('showDatabaseBackupsAction', 1);
+
+        self::$client->request('GET', $url);
+        self::assertResponseRedirects('/');
+
+        $this->loginAsAdmin();
+        self::$client->request('GET', $url);
+        self::assertResponseStatusCodeSame(403);
+
+        $this->loginAsUser();
+        self::$client->request('GET', $url);
+        self::assertResponseRedirects();
+    }
+
+    public function testDelete(): void
+    {
+        $url = $this->getActionUrl('delete', 1);
+
+        self::$client->request('GET', $url);
+        self::assertResponseRedirects('/');
+
+        $this->loginAsUser();
+        self::$client->request('GET', $url);
+        self::assertResponseRedirects();
+    }
+
     protected function getControllerClass(): string
     {
         return DatabaseCrudController::class;