Added support for non-versioned snapshots

Author: acecilia

MODULE.bazel

@@ -757,8 +757,10 @@ dev_maven.install(
         "androidx.annotation:annotation:1.6.0",
         # https://github.com/bazel-contrib/rules_jvm_external/issues/1409
         "com.squareup.okhttp3:okhttp:4.12.0",
-        # Snapshot pinning support: https://github.com/bazel-contrib/rules_jvm_external/pull/1412
+        # Versioned snapshot pinning support: https://github.com/bazel-contrib/rules_jvm_external/pull/1412
         "com.google.guava:guava:999.0.0-HEAD-jre-SNAPSHOT",
+        # Non-versioned snapshot pinning support: https://github.com/bazel-contrib/rules_jvm_external/pull/1412
+        "org.seleniumhq.selenium:selenium-java:4.34.0-SNAPSHOT",
     ],
     generate_compat_repositories = True,
     lock_file = "//tests/custom_maven_install:regression_testing_gradle_install.json",

private/extensions/download_pinned_deps.bzl

@@ -37,7 +37,9 @@ def download_pinned_deps(mctx, artifacts, http_files, has_m2local):
 
         http_file(
             name = http_file_repository_name,
-            sha256 = artifact["sha256"],
+            # sha256 is optional: non-versioned snapshots may not have it
+            # See: https://github.com/bazel-contrib/rules_jvm_external/pull/1412
+            sha256 = artifact.get("sha256"),
             urls = urls,
             # https://github.com/bazelbuild/rules_jvm_external/issues/1028
             downloaded_file_path = "v1/%s" % artifact["file"] if artifact["file"] else artifact["file"],

private/rules/coursier.bzl

@@ -597,7 +597,9 @@ def _pinned_coursier_fetch_impl(repository_ctx):
             http_files.extend([
                 "    http_file(",
                 "        name = \"%s\"," % http_file_repository_name,
-                "        sha256 = \"%s\"," % artifact["sha256"],
+                # sha256 is optional: non-versioned snapshots may not have it
+                # See: https://github.com/bazel-contrib/rules_jvm_external/pull/1412
+                "        sha256 = \"%s\"," % artifact.get("sha256", None),
                 # repository_ctx should point to external/$repository_ctx.name
                 # The http_file should point to external/$http_file_repository_name
                 # File-path is relative defined from http_file traveling to repository_ctx.

private/tools/java/com/github/bazelbuild/rules_jvm_external/resolver/lockfile/V2LockFile.java

@@ -231,7 +231,15 @@ public Map<String, Object> render() {
           @SuppressWarnings("unchecked")
           Map<String, String> shasums =
               (Map<String, String>) artifactValue.computeIfAbsent("shasums", k -> new TreeMap<>());
-          info.getSha256().ifPresent(sha -> shasums.put(classifier, sha));
+          
+          // For non-versioned snapshots, their content can change any moment, so we need to avoid storing the SHA256 
+          boolean isNonVersionedSnapshot = coords.getVersion().endsWith("-SNAPSHOT") && coords.getVersionRevision() == null;
+          if (isNonVersionedSnapshot) {
+            // Classifier indicates the files associated to the dependency: store it even if the sha is not present
+            shasums.put(classifier, null);
+          } else {
+            info.getSha256().ifPresent(sha -> shasums.put(classifier, sha));
+          }
 
           info.getRepositories()
               .forEach(