Skip to content

Commit 8f2e852

Browse files
authored
Remove target constraint (#3879)
Because `rules_js` 3.x started consuming the runtime toolchain, this constraint is no longer needed. It is in fact problematic now because it prevents building multi-platform images. See: #3854 aspect-build/rules_js#2499 ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [x] Docs have been added / updated (for bug fixes / features) ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature (please, look at the "Scope of the project" section in the README.md file) - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? <!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> Issue Number: #3854 ## What is the new behavior? ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information Slack: https://bazelbuild.slack.com/archives/CEZUUKQ6P/p1763167547013579
1 parent b329866 commit 8f2e852

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

nodejs/private/nodejs_toolchains_repo.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ See https://github.com/bazel-contrib/rules_nodejs/issues/3795.
9696
toolchain(
9797
name = "{platform}_toolchain",
9898
exec_compatible_with = {compatible_with},
99-
target_compatible_with = {compatible_with}, # prevent Node from this toolchain being bundled by js_image_oci to incompatible target platforms (https://github.com/bazel-contrib/rules_nodejs/issues/3854)
10099
toolchain = "@{user_node_repository_name}_{platform}//:toolchain",
101100
toolchain_type = "@rules_nodejs//nodejs:toolchain_type",
102101
)

0 commit comments

Comments
 (0)