Skip to content

Commit 034653b

Browse files
committed
feat(pipstar): extract the wheel without python
With this we start extracting the wheel without Python and it becomes a requirement only when patching (we will extract the wheel without Python, patch it and then re-compress it which makes a very inefficient process). This should result in much faster executions.
1 parent a9056b1 commit 034653b

File tree

1 file changed

+3
-14
lines changed

1 file changed

+3
-14
lines changed

python/private/pypi/whl_library.bzl

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -377,20 +377,9 @@ def _whl_library_impl(rctx):
377377
#
378378
# Remove non-pipstar and config_load check when we release rules_python 2.
379379
if enable_pipstar:
380-
pypi_repo_utils.execute_checked(
381-
rctx,
382-
op = "whl_library.ExtractWheel({}, {})".format(rctx.attr.name, whl_path),
383-
python = python_interpreter,
384-
arguments = args + [
385-
"--whl-file",
386-
whl_path,
387-
"--enable-pipstar",
388-
],
389-
srcs = rctx.attr._python_srcs,
390-
environment = environment,
391-
quiet = rctx.attr.quiet,
392-
timeout = rctx.attr.timeout,
393-
logger = logger,
380+
rctx.extract(
381+
archive = whl_path,
382+
output = "site-packages",
394383
)
395384

396385
metadata = whl_metadata(

0 commit comments

Comments
 (0)