Add an analysis time check to avoid invoking actool when the asset catalog has no assets to compile. #2796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
requested review from
aaronsky,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
aaronsky
approved these changes
Oct 30, 2025
Contributor
aaronsky
left a comment
aaronsky
left a comment
There was a problem hiding this comment.
hopefully this doesn't make cherry picking earlier commits more difficult
aaronsky
requested changes
Oct 30, 2025
Contributor
aaronsky
left a comment
aaronsky
left a comment
There was a problem hiding this comment.
actually no, we shouldn't take this until other commits affecting actool from this past summer are in. asset_files gets clobbered in this implementation by lines that are not present upstream
Contributor
Author
Alright, I'll make it a draft until we cherry pick stuff from the list of commits you shared. |
aaronsky
reviewed
Nov 13, 2025
…talog has no assets to compile. PiperOrigin-RevId: 819717389 (cherry picked from commit 5557de8)
adincebic
force-pushed
the
adin/cp-5557de8c0697fe3a9cb83214a7cce2357a355f3e
branch
from
db5aee8 to
dc53fc7
Compare
aaronsky
reviewed
Nov 16, 2025
adincebic
force-pushed
the
adin/cp-5557de8c0697fe3a9cb83214a7cce2357a355f3e
branch
from
d29d904 to
582f206
Compare
aaronsky
approved these changes
Nov 16, 2025
adincebic
deleted the
adin/cp-5557de8c0697fe3a9cb83214a7cce2357a355f3e
branch
adincebic
referenced
this pull request
Nov 21, 2025
…talog has no assets to compile. PiperOrigin-RevId: 819717389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 5557de8c0697fe3a9cb83214a7cce2357a355f3e