Proposal to add segment created metadata - rejected #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbilt
force-pushed
the
segment-created-metadata
branch
from
1d16e05 to
9aa8853
Compare
j616
changed the title
j616
approved these changes
Nov 25, 2025
Contributor
j616
left a comment
j616
left a comment
There was a problem hiding this comment.
Thank you for your work on this. This looks good. I've updated the PR title so it doesn't confuse people in the changelog.
Contributor
|
Looks like there's one more linting error. I'll merge once thats sorted |
j616
approved these changes
Nov 25, 2025
Contributor
|
Slightly unhelpful message there. But does this need rebasing again? |
j616
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add created and created_by fields to the segment metadata model
Jira Issue (if relevant)
Jira URL:
Related PRs
Not applicable
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.