lint

Author: deirn

frontend/css/journal-table.css

@@ -42,7 +42,7 @@
 }
 
 .journal .head .container {
-  padding: 1.5em 1.5em 0 1.5em;
+  padding: 1.5em 1.5em 0;
   margin-bottom: 0.25em;
 }
 
@@ -222,7 +222,7 @@
   }
 
   .journal .head .container {
-    padding: 1em 1em 0 1em;
+    padding: 1em 1em 0;
   }
 
   .journal .head .table-head {

frontend/src/api/validators.ts

@@ -152,8 +152,10 @@ const account_budget = object({
 });
 export type AccountBudget = ValidationT<typeof account_budget>;
 
-const simple_counter_inventory = record(number)
-export type SimpleCounterInventory = ValidationT<typeof simple_counter_inventory>
+const simple_counter_inventory = record(number);
+export type SimpleCounterInventory = ValidationT<
+  typeof simple_counter_inventory
+>;
 
 const account_journal_entry = tuple(
   entryValidator,

frontend/src/entries/index.ts

@@ -25,8 +25,8 @@ export class Posting {
     readonly meta: EntryMetadata,
     readonly account: string,
     readonly amount: string,
-    readonly flag: string | null
-  ) { }
+    readonly flag: string | null,
+  ) {}
 
   /** Create a new empty Posting. */
   static empty(): Posting {
@@ -53,7 +53,8 @@ export class Posting {
 
   static validator: Validator<Posting> = (json) =>
     Posting.raw_validator(json).map(
-      ({ meta, account, amount, flag }) => new Posting(meta, account, amount, flag),
+      ({ meta, account, amount, flag }) =>
+        new Posting(meta, account, amount, flag),
     );
 }
 
@@ -83,7 +84,7 @@ abstract class EntryBase<T extends string> {
     readonly entry_hash: string,
     readonly sortFlag: string,
     readonly sortNarration: string,
-  ) { }
+  ) {}
 
   /** Clone. */
   clone(): this {
@@ -159,7 +160,14 @@ export class Balance extends EntryBase<"Balance"> {
 
   /** Create a new empty Balance entry on the date. */
   static empty(date: string): Balance {
-    return new Balance(new EntryMetadata(), date, "", "", RawAmount.empty(), null);
+    return new Balance(
+      new EntryMetadata(),
+      date,
+      "",
+      "",
+      RawAmount.empty(),
+      null,
+    );
   }
 
   private static raw_validator = object({
@@ -169,7 +177,7 @@ export class Balance extends EntryBase<"Balance"> {
     entry_hash: string,
     account: string,
     amount: RawAmount.validator,
-    diff_amount: optional(Amount.validator)
+    diff_amount: optional(Amount.validator),
   });
 
   static validator: Validator<Balance> = (json) =>
@@ -442,14 +450,14 @@ export class CustomValue {
   constructor(
     readonly dtype: string,
     readonly value: unknown,
-  ) { }
+  ) {}
 
   toString(): string {
     if (this.dtype === "<class 'beancount.core.amount.Amount'>") {
-      const a = this.value as Amount
-      return `${a.number.toString()} ${a.currency}`
+      const a = this.value as Amount;
+      return `${a.number.toString()} ${a.currency}`;
     }
-    return this.value as string
+    return this.value as string;
   }
 
   private static raw_validator = object({

frontend/src/format.ts

@@ -16,7 +16,7 @@ export function localeFormatter(
   locale: string | null,
   precision = 2,
 ): (num: number) => string {
-  let f;
+  let f: (value: number) => string;
   if (locale == null) {
     f = format(`.${precision.toString()}f`);
   } else {

frontend/src/journal/JournalEntry.svelte

@@ -1,6 +1,8 @@
 <script lang="ts">
+  /* eslint-disable @typescript-eslint/no-confusing-void-expression */
+
   import type { MouseEventHandler } from "svelte/elements";
-  import { addFilter, escape_for_regex } from ".";
+
   import type { AccountJournalEntry } from "../api/validators";
   import type { Document, EntryMetadata, Transaction } from "../entries";
   import { type Entry } from "../entries";
@@ -10,6 +12,7 @@
   import { currency_name } from "../stores";
   import { ctx } from "../stores/format";
   import type { JournalShowEntry } from "../stores/journal";
+  import { addFilter, escape_for_regex } from ".";
 
   interface Props {
     index: number;
@@ -62,9 +65,9 @@
     return liClasses;
   });
 
-  const unitRegex = /([\d\.\-]+)\s+(\w+)/;
-  const costRegex = /\{([\d\.\-]+)\s+(\w+),\s([\w\-]+)\}/;
-  const priceRegex = /@\s([\d\.\-]+)\s+(\w+)/;
+  const unitRegex = /([\d.-]+)\s+(\w+)/;
+  const costRegex = /\{([\d.-]+)\s+(\w+),\s([\w-]+)\}/;
+  const priceRegex = /@\s([\d.-]+)\s+(\w+)/;
 
   type PostingAmounts = [
     [amount: string, currency: string],
@@ -73,9 +76,10 @@
   ];
 
   function splitPostingAmount(str: string): PostingAmounts {
-    const amount = str.match(unitRegex)!;
-    const cost = str.match(costRegex);
-    const price = str.match(priceRegex);
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const amount = unitRegex.exec(str)!;
+    const cost = costRegex.exec(str);
+    const price = priceRegex.exec(str);
 
     return [
       [amount[1], amount[2]],
@@ -93,13 +97,15 @@
 
   type ClickHandler = MouseEventHandler<HTMLElement>;
 
-  const clickTagLink: ClickHandler = ({ currentTarget }) =>
+  const clickTagLink: ClickHandler = ({ currentTarget }) => {
     addFilter(currentTarget.innerText);
+  };
 
   // Note: any special characters in the payee string are escaped so the
   // filter matches against the payee literally.
-  const clickPayee: ClickHandler = ({ currentTarget }) =>
+  const clickPayee: ClickHandler = ({ currentTarget }) => {
     addFilter(`payee:"^${escape_for_regex(currentTarget.innerText)}$"`);
+  };
 
   const clickMetaKey: ClickHandler = ({ currentTarget }) => {
     const expr = `${currentTarget.innerText}""`;
@@ -127,6 +133,7 @@
 </script>
 
 {#snippet amount(amount: Amount | RawAmount, cls: string)}
+  <!-- eslint-disable-next-line @typescript-eslint/strict-boolean-expressions -->
   {#if !amount.number}
     <span class={cls}></span>
   {:else}
@@ -283,7 +290,8 @@
       {@render metadataIndicators(e.meta)}
       {#if e.t === "Transaction"}
         {#each e.postings as posting, index (index)}
-          <span class={posting.flag ? flagToTypes(posting.flag) : null}></span>
+          <span class={posting.flag != null ? flagToTypes(posting.flag) : null}
+          ></span>
           {@render metadataIndicators(posting.meta)}
         {/each}
       {/if}
@@ -302,23 +310,29 @@
     {#if showChangeAndBalance}
       {#if e.t === "Transaction"}
         <span class="change num">
-          {#each Object.entries(change ?? {}) as [currency, number]}
-            {$ctx.amount(number, currency)}<br />
-          {/each}
+          {#if change}
+            {#each Object.entries(change) as [currency, number], index (index)}
+              <!-- eslint-disable-next-line @typescript-eslint/no-unsafe-argument -->
+              {$ctx.amount(number, currency)}<br />
+            {/each}
+          {/if}
         </span>
       {/if}
       <span class="num">
-        {#each Object.entries(balance ?? {}) as [currency, number]}
-          {$ctx.amount(number, currency)}<br />
-        {/each}
+        {#if balance}
+          {#each Object.entries(balance) as [currency, number], index (index)}
+            <!-- eslint-disable-next-line @typescript-eslint/no-unsafe-argument -->
+            {$ctx.amount(number, currency)}<br />
+          {/each}
+        {/if}
       </span>
     {/if}
   </p>
   {@render metadata(e.meta, e.entry_hash)}
   {#if showPostings && e.t === "Transaction" && e.postings.length > 0}
     <ul class="postings">
       {#each e.postings as posting, index (index)}
-        <li class={posting.flag ? flagToTypes(posting.flag) : null}>
+        <li class={posting.flag != null ? flagToTypes(posting.flag) : null}>
           <p>
             <span class="datecell"></span>
             <span class="flag">{posting.flag ?? ""}</span>

frontend/src/journal/JournalTable.svelte

@@ -1,11 +1,14 @@
 <script lang="ts">
   import { createVirtualizer } from "@tanstack/svelte-virtual";
-  import { onDestroy, onMount, tick, type Snippet } from "svelte";
+  import { onDestroy, onMount, type Snippet, tick } from "svelte";
   import { derived, writable } from "svelte/store";
 
+  import type { AccountJournalEntry } from "../api/validators";
   import type { Entry } from "../entries";
   import { _ } from "../i18n";
+  import Header from "../sidebar/Header.svelte";
   import { Sorter, StringColumn } from "../sort";
+  import { hideHeader } from "../stores";
   import {
     journalShow as journalShowStore,
     type JournalShowEntry,
@@ -14,9 +17,6 @@
   } from "../stores/journal";
   import JournalEntry from "./JournalEntry.svelte";
   import JournalFilters from "./JournalFilters.svelte";
-  import type { AccountJournalEntry } from "../api/validators";
-  import Header from "../sidebar/Header.svelte";
-  import { hideHeader } from "../stores";
 
   type E = Entry | AccountJournalEntry;
   interface Props {
@@ -114,8 +114,12 @@
   );
 
   // Update the manual store when the prop update.
-  $effect(() => entries.set(entriesProp));
-  onDestroy(() => unsub());
+  $effect(() => {
+    entries.set(entriesProp);
+  });
+  onDestroy(() => {
+    unsub();
+  });
 
   function headerClick(e: MouseEvent & { currentTarget: HTMLSpanElement }) {
     const name = e.currentTarget.getAttribute("data-sort-name");
@@ -144,8 +148,9 @@
       count: sortedEntries.length + 1,
       getItemKey: depend(
         sortedEntries,
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+
         (sortedEntries) => (i) =>
+          // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
           i === 0 ? "head" : entry(sortedEntries[i - 1]!).entry_hash,
       ),
       getScrollElement: depend(vlistOuter, (ol) => () => ol ?? null),
@@ -156,7 +161,9 @@
   let items = $derived($virtualizer.getVirtualItems());
 
   $effect(() => {
-    if (head) $virtualizer.measureElement(head);
+    if (head) {
+      $virtualizer.measureElement(head);
+    }
     if (vlistItems.length) {
       vlistItems.forEach((li) => {
         $virtualizer.measureElement(li);
@@ -171,10 +178,14 @@
       // Wait for update tick so keyboard shortcut not duplicated.
       if (mediaQuery.matches) {
         $hideHeader = true;
-        tick().then(() => mobileHeader = true);
+        void tick().then(() => {
+          mobileHeader = true;
+        });
       } else {
         mobileHeader = false;
-        tick().then(() => $hideHeader = false);
+        void tick().then(() => {
+          $hideHeader = false;
+        });
       }
     };
 

frontend/src/reports/accounts/AccountReport.svelte

@@ -1,15 +1,17 @@
 <script lang="ts">
+  /* eslint-disable @typescript-eslint/no-confusing-void-expression */
+
   import { parseChartData } from "../../charts";
   import ChartSwitcher from "../../charts/ChartSwitcher.svelte";
   import { chartContext } from "../../charts/context";
   import { urlForAccount } from "../../helpers";
   import { _ } from "../../i18n";
+  import JournalTable from "../../journal/JournalTable.svelte";
   import { is_non_empty } from "../../lib/array";
   import { intervalLabel } from "../../lib/interval";
   import { interval } from "../../stores";
   import IntervalTreeTable from "../../tree-table/IntervalTreeTable.svelte";
   import type { AccountReportProps } from ".";
-  import JournalTable from "../../journal/JournalTable.svelte";
 
   let {
     account,

frontend/src/sort/index.ts

@@ -45,7 +45,7 @@ export class Sorter<T = unknown> {
   constructor(
     readonly column: SortColumn<T>,
     readonly order: SortOrder,
-  ) { }
+  ) {}
 
   /** Get a new sorter by switching to a possibly different column. */
   switchColumn(column: SortColumn<T>): Sorter<T> {
@@ -91,7 +91,7 @@ function sort_internal<T, U>(
 
 /** A SortColumn that does no sorting. */
 export class UnsortedColumn<T> implements SortColumn<T> {
-  constructor(readonly name: string) { }
+  constructor(readonly name: string) {}
 
   sort(data: readonly T[]): readonly T[] {
     return data;
@@ -104,8 +104,12 @@ export class NumberColumn<T> implements SortColumn<T> {
 
   constructor(
     readonly name: string,
-    private readonly value: (row: Readonly<T>, index: number, array: readonly T[]) => number,
-  ) { }
+    private readonly value: (
+      row: Readonly<T>,
+      index: number,
+      array: readonly T[],
+    ) => number,
+  ) {}
 
   sort(data: readonly T[], direction: SortDirection): readonly T[] {
     return sort_internal(data, this.value, this.compare, direction);
@@ -126,8 +130,12 @@ export class StringColumn<T> implements SortColumn<T> {
 
   constructor(
     readonly name: string,
-    private readonly value: (row: Readonly<T>, index: number, array: readonly T[]) => string,
-  ) { }
+    private readonly value: (
+      row: Readonly<T>,
+      index: number,
+      array: readonly T[],
+    ) => string,
+  ) {}
 
   sort(data: readonly T[], direction: 1 | -1): readonly T[] {
     return sort_internal(data, this.value, this.compare, direction);

src/fava/json_api.py

@@ -21,7 +21,6 @@
 from typing import TYPE_CHECKING
 
 from flask import Blueprint
-from flask import get_template_attribute
 from flask import jsonify
 from flask import request
 from flask_babel import gettext
@@ -791,5 +790,5 @@ def get_account_report() -> AccountReportJournal | AccountReportTree:
     )
     return AccountReportJournal(
         charts,
-        journal=[[serialise(e[0]), e[1], e[2]] for e in journal]
+        journal=[[serialise(e[0]), e[1], e[2]] for e in journal],  # type: ignore[misc]
     )