feat: move logging to esm modules

Author: chmelevskij

gulpfile.js

@@ -319,7 +319,8 @@ function dist_rollup() {
                 // I will be picked up by rollup and bundled accordingly.
                 'components/init': 'src/components/init.js',
                 'js/main_cordova': 'src/js/main_cordova.js',
-                'js/utils/common': 'src/js/utils/common.js'
+                'js/utils/common': 'src/js/utils/common.js',
+                'js/tabs/logging': 'src/js/tabs/logging.js'
             },
             plugins: [
                 alias({

src/js/tabs/logging.js

@@ -1,7 +1,7 @@
-'use strict';
+import { millitime } from '../utils/common.js';
 
-TABS.logging = {};
-TABS.logging.initialize = function (callback) {
+const logging = {};
+logging.initialize = function (callback) {
 
     if (GUI.active_tab != 'logging') {
         GUI.active_tab = 'logging';
@@ -319,6 +319,9 @@ TABS.logging.initialize = function (callback) {
     }
 };
 
-TABS.logging.cleanup = function (callback) {
+logging.cleanup = function (callback) {
     if (callback) callback();
 };
+
+// TODO: only for transition to modules, drop this eventually
+window.TABS.logging = logging;

src/js/utils/common.js

@@ -79,8 +79,8 @@ export function generateVirtualApiVersions() {
     }
 }
 
+// TODO: these are temp binding while transition to module happens
 window.microtime = microtime;
-window.millitime = millitime;
 window.degToRad = degToRad;
 window.bytesToSize = bytesToSize;
 window.checkChromeRuntimeError = checkChromeRuntimeError;

src/main.html

@@ -123,7 +123,8 @@
     <script type="text/javascript" src="./js/tabs/led_strip.js"></script>
     <script type="text/javascript" src="./js/tabs/sensors.js"></script>
     <script type="text/javascript" src="./js/tabs/cli.js"></script>
-    <script type="text/javascript" src="./js/tabs/logging.js"></script>
+    <!-- TODO: might be removed when everythign is in modules -->
+    <script type="module" src="./js/tabs/logging.js"></script>
     <script type="text/javascript" src="./js/tabs/onboard_logging.js"></script>
     <script type="text/javascript" src="./js/FirmwareCache.js"></script>
     <script type="text/javascript" src="./js/tabs/firmware_flasher.js"></script>