From 2c42a665fce2bcdf93928d9a340dd797b2d8bfb8 Mon Sep 17 00:00:00 2001
From: Mark Haslinghuis <mark@numloq.nl>
Date: Tue, 16 Dec 2025 21:40:09 +0100
Subject: [PATCH 1/3] Callback is handled in serial.js already

---
 src/js/protocols/VirtualSerial.js | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/js/protocols/VirtualSerial.js b/src/js/protocols/VirtualSerial.js
index abb2c16257c..a62bad6a7d5 100644
--- a/src/js/protocols/VirtualSerial.js
+++ b/src/js/protocols/VirtualSerial.js
@@ -18,12 +18,11 @@ class VirtualSerial {
         this.transmitting = false;
         this.outputBuffer = [];
     }
-    connect(port, options, callback) {
+    connect(port, options) {
         if (!this.openCanceled) {
             this.connected = true;
             this.connectionId = VIRTUAL;
             this.bitrate = 115200;
-            callback();
         }
     }
     disconnect(callback) {

From 4b4ce38e648991ef4605595cfc41333b56f57cf4 Mon Sep 17 00:00:00 2001
From: Mark Haslinghuis <mark@numloq.nl>
Date: Tue, 16 Dec 2025 21:52:44 +0100
Subject: [PATCH 2/3] Remove unused openCancelled

---
 src/js/protocols/VirtualSerial.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/js/protocols/VirtualSerial.js b/src/js/protocols/VirtualSerial.js
index a62bad6a7d5..02644009872 100644
--- a/src/js/protocols/VirtualSerial.js
+++ b/src/js/protocols/VirtualSerial.js
@@ -9,7 +9,6 @@ class VirtualSerial {
     constructor() {
         this.connected = false;
         this.connectionId = false;
-        this.openCanceled = false;
         this.bitrate = 0;
         this.bytesReceived = 0;
         this.bytesSent = 0;
@@ -19,11 +18,9 @@ class VirtualSerial {
         this.outputBuffer = [];
     }
     connect(port, options) {
-        if (!this.openCanceled) {
-            this.connected = true;
-            this.connectionId = VIRTUAL;
-            this.bitrate = 115200;
-        }
+        this.connected = true;
+        this.connectionId = VIRTUAL;
+        this.bitrate = 115200;
     }
     disconnect(callback) {
         this.connected = false;

From 8b2520d8d748b206995d995d2e2f6a661c52fb2a Mon Sep 17 00:00:00 2001
From: Mark Haslinghuis <mark@numloq.nl>
Date: Tue, 16 Dec 2025 22:00:25 +0100
Subject: [PATCH 3/3] Remove unused callback from disconnect and add return
 values

---
 src/js/protocols/VirtualSerial.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/js/protocols/VirtualSerial.js b/src/js/protocols/VirtualSerial.js
index 02644009872..58f1500e7a8 100644
--- a/src/js/protocols/VirtualSerial.js
+++ b/src/js/protocols/VirtualSerial.js
@@ -21,18 +21,18 @@ class VirtualSerial {
         this.connected = true;
         this.connectionId = VIRTUAL;
         this.bitrate = 115200;
+        return true;
     }
-    disconnect(callback) {
+    disconnect() {
         this.connected = false;
         this.outputBuffer = [];
         this.transmitting = false;
         if (this.connectionId) {
             this.connectionId = false;
             this.bitrate = 0;
-            if (callback) {
-                callback(true);
-            }
+            return true;
         }
+        return false;
     }
     getConnectedPort() {
         return this.connectionId;