Use Ktor for Nextcloud Login Flow #1817
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace OkHttp with Ktor for HTTP requests - Update URL handling to use Ktor's `Url` class - Adjust `postForJson` method to use Ktor's HTTP client - Refactor URL building logic for login flow initiation
- Migrate to Ktor's ContentNegotiation plugin for JSON handling - Update dependencies and configuration for Ktor serialization - Refactor `NextcloudLoginFlow` to use Ktor's JSON serialization
rfc2822
changed the title
Copilot finished reviewing on behalf of
rfc2822
November 17, 2025 12:30
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Nextcloud Login Flow implementation from OkHttp to Ktor, using Kotlin Serialization for JSON parsing instead of manual JSON handling with JSONObject.
Key changes:
- Migrated
NextcloudLoginFlowfrom OkHttp to Ktor HTTP client with automatic JSON deserialization via Kotlin Serialization - Updated
NextcloudLoginModelto use Ktor'sUrltype instead of OkHttp'sHttpUrl - Made Conscrypt loading conditional to support unit tests where it's unavailable
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Added Ktor content negotiation and kotlinx serialization dependencies, plus Kotlin serialization plugin |
| app/build.gradle.kts | Applied Kotlin serialization plugin and added Ktor serialization dependencies |
| app/src/main/kotlin/at/bitfire/davdroid/network/NextcloudLoginFlow.kt | Refactored from OkHttp to Ktor with Kotlin Serialization data classes for JSON responses |
| app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLoginModel.kt | Updated to use Ktor Url type and simplified URL validation logic |
| app/src/main/kotlin/at/bitfire/davdroid/network/HttpClientBuilder.kt | Added ContentNegotiation plugin with JSON serialization support to Ktor client builder |
| app/src/main/kotlin/at/bitfire/davdroid/network/ConscryptIntegration.kt | Added availability check before loading Conscrypt to enable unit tests |
| app/src/test/kotlin/at/bitfire/davdroid/network/NextcloudLoginFlowTest.kt | Added unit tests for URL transformation logic in login flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/test/kotlin/at/bitfire/davdroid/network/NextcloudLoginFlowTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/at/bitfire/davdroid/ui/setup/NextcloudLoginModel.kt
Outdated
Show resolved
Hide resolved
rfc2822
force-pushed
the
1812-ktor-use-ktor-for-nextcloud-login-flow
branch
from
145cc6d to
8580fca
Compare
# Conflicts: # app/src/main/kotlin/at/bitfire/davdroid/network/NextcloudLoginFlow.kt
Member
|
Needs a merge, there is still the empty HttpClient file. |
# Conflicts: # app/src/main/kotlin/at/bitfire/davdroid/network/HttpClient.kt # gradle/libs.versions.toml
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor Nextcloud Login Flow to Ktor (because we want to rewrite everything to Ktor).
Short description
NextcloudLoginFlowto use KtorNextcloudLoginModelto use the new login flow classTo allow unit tests that include a
HttpClientBuilder, Conscrypt is now only loaded when it's available (and it's not available in unit tests).Checklist