[PM-28339] Remove nested LazyVStacks to improve scroll performance (#2191)

Author: matt-livefront

BitwardenShared/UI/Tools/Send/Send/SendList/SendListView.swift

@@ -132,7 +132,7 @@ private struct MainSendListView: View {
     /// interface, and a message indicating that no results were found.
     @ViewBuilder private var search: some View {
         if store.state.searchText.isEmpty || !store.state.searchResults.isEmpty {
-            LazyVStack(spacing: 0) {
+            VStack(spacing: 0) {
                 if !store.state.searchResults.isEmpty {
                     sendItemSectionView(
                         sectionName: nil,
@@ -149,7 +149,7 @@ private struct MainSendListView: View {
     /// The list for this view, displayed when there is content to display.
     @ViewBuilder
     private func list(sections: [SendListSection]) -> some View {
-        LazyVStack(alignment: .leading, spacing: 16) {
+        VStack(alignment: .leading, spacing: 16) {
             if store.state.isSendDisabled {
                 InfoContainer(Localizations.sendDisabledWarning)
             }

BitwardenShared/UI/Vault/Vault/AutofillList/VaultAutofillListView.swift

@@ -142,7 +142,7 @@ private struct VaultAutofillListSearchableView: View {
     /// A view for displaying a list of sections with ciphers.
     @ViewBuilder
     private func cipherCombinedListView(_ sections: [VaultListSection]) -> some View {
-        LazyVStack(spacing: 16) {
+        VStack(spacing: 16) {
             ForEach(sections) { section in
                 VaultListSectionView(
                     section: section,

BitwardenShared/UI/Vault/Vault/VaultList/VaultListView.swift

@@ -249,7 +249,7 @@ private struct SearchableVaultListView: View {
     ///
     @ViewBuilder
     private func vaultContents(with sections: [VaultListSection]) -> some View {
-        LazyVStack(spacing: 20) {
+        VStack(spacing: 20) {
             vaultFilterRow
 
             ForEach(sections) { section in