diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 708495d..f7b05b3 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -22,10 +22,14 @@ on: default: false secrets: DOCKER_USERNAME: - description: Never passed by a caller. The release environment's secret of this name. + description: >- + Map it by name from the caller. The value comes from the release environment, which the + caller's job can't read; without the mapping the environment job sees it empty. required: false DOCKER_TOKEN: - description: Never passed by a caller. The release environment's secret of this name. + description: >- + Map it by name from the caller. The value comes from the release environment, which the + caller's job can't read; without the mapping the environment job sees it empty. required: false outputs: images: diff --git a/README.md b/README.md index dd727ad..cb1681a 100644 --- a/README.md +++ b/README.md @@ -30,9 +30,10 @@ jobs: Use the SHA of a `v*` tag of this repository, never a branch. Tags here are created only by the release App and can't be moved or deleted, so a version comment always matches its SHA. -`release-check.yml` and `publish.yml` read the release App key in jobs that run in the caller's `release` -environment. A reusable workflow gets an environment secret only when the caller passes it, so map it by -name as above, alongside any other secrets such as `registry-token`. The caller's own job can't read the +`release-check.yml` and `publish.yml` read the release App key, and `docker.yml` reads `DOCKER_USERNAME` and +`DOCKER_TOKEN`, in jobs that run in the caller's `release` environment. A reusable workflow gets an +environment secret only when the caller passes it, so map each by name as above, alongside any other secrets +such as `registry-token`. The caller's own job can't read the value; GitHub supplies it inside the environment. Call `dev-security.yml` from a workflow that runs on `pull_request`, with a job named `dev-security`, so the