Update all things to PHP 8.4 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates configuration files to align with PHP 8.4 and deprecates the develop branch. Key changes include:
- Updating Dependabot's target branch from "develop" to "master".
- Adding the "master" branch to the test workflow configuration.
- Retaining the "develop" branch in the test workflow configuration despite the deprecation intent.
Reviewed Changes
| File | Description |
|---|---|
| .github/dependabot.yml | Updated target branch to "master" to reflect branch deprecation |
| .github/workflows/test.yml | Added "master" branch but still lists the deprecated "develop" branch |
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:8
- The 'develop' branch is still present in the push triggers despite the intention to deprecate it. Please remove 'develop' from the configuration to fully support the branch deprecation.
- develop
sunxyw
approved these changes
Mar 10, 2025
Collaborator
sunxyw
left a comment
sunxyw
left a comment
There was a problem hiding this comment.
似乎大部分都只是把引用的类名提升到命名空间。looks good to me
github-actions
bot
added
lifecycle/ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
顺便，废弃 develop 分支吧，应该不会再需要了。