Use DI to register command

Author: Florian Eckerstorfer

Command/InstallSymfony2CodingStandardCommand.php

@@ -10,7 +10,7 @@
 
 namespace Bc\Bundle\Symfony2CodingStandardBundle\Command;
 
-use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -28,8 +28,22 @@
  *
  * @codeCoverageIgnore
  */
-class InstallSymfony2CodingStandardCommand extends ContainerAwareCommand
+class InstallSymfony2CodingStandardCommand extends Command
 {
+    /** @var string */
+    private $rootDir;
+
+    /**
+     * Constructor.
+     *
+     * @param string $rootDir Root directory
+     */
+    public function __construct($rootDir)
+    {
+        $this->rootDir = $rootDir;
+        parent::__construct();
+    }
+
     /**
      * {@inheritDoc}
      */
@@ -43,7 +57,7 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $vendorDir = sprintf('%s/../vendor', $this->getContainer()->getParameter('kernel.root_dir'));
+        $vendorDir = sprintf('%s/../vendor', $this->rootDir);
         $codeSnifferDir = sprintf('%s/squizlabs/php_codesniffer', $vendorDir);
 
         if (false === file_exists($codeSnifferDir)) {

DependencyInjection/BcSymfony2CodingStandardExtension.php

@@ -0,0 +1,40 @@
+<?php
+/**
+ * This file is part of BcSymfony2CodingStandardBundle.
+ *
+ * (c) 2013 Florian Eckerstorfer <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Bc\Bundle\Symfony2CodingStandardBundle\DependencyInjection;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\Config\FileLocator;
+use Symfony\Component\HttpKernel\DependencyInjection\Extension;
+use Symfony\Component\DependencyInjection\Loader;
+
+/**
+ * BcSymfony2CodingStandardExtension
+ *
+ * @package    BcSymfony2CodingStandardBundle
+ * @subpackage DependencyInjection
+ * @author     Florian Eckerstorfer <[email protected]>
+ * @copyright  2013 Florian Eckerstorfer
+ * @license    http://opensource.org/licenses/MIT The MIT License
+ */
+class BcSymfony2CodingStandardExtension extends Extension
+{
+    /**
+     * {@inheritDoc}
+     */
+    public function load(array $configs, ContainerBuilder $container)
+    {
+        $configuration = new Configuration();
+        $config = $this->processConfiguration($configuration, $configs);
+
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader->load('services.xml');
+    }
+}

DependencyInjection/Configuration.php

@@ -0,0 +1,37 @@
+<?php
+/**
+ * This file is part of BcSymfony2CodingStandardBundle.
+ *
+ * (c) 2013 Florian Eckerstorfer <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace Bc\Bundle\Symfony2CodingStandardBundle\DependencyInjection;
+
+use Symfony\Component\Config\Definition\Builder\TreeBuilder;
+use Symfony\Component\Config\Definition\ConfigurationInterface;
+
+/**
+ * Configuration
+ *
+ * @package    BcSymfony2CodingStandardBundle
+ * @subpackage DependencyInjection
+ * @author     Florian Eckerstorfer <[email protected]>
+ * @copyright  2013 Florian Eckerstorfer
+ * @license    http://opensource.org/licenses/MIT The MIT License
+ */
+class Configuration implements ConfigurationInterface
+{
+    /**
+     * {@inheritDoc}
+     */
+    public function getConfigTreeBuilder()
+    {
+        $treeBuilder = new TreeBuilder();
+        $rootNode = $treeBuilder->root('bc_symfony2_coding_standard');
+
+        return $treeBuilder;
+    }
+}

README.md

@@ -18,7 +18,10 @@ Compatiblity
     <th>BcSymfony2CodingStandardBundle</th><th>Symfony</th>
   </tr>
   <tr>
-    <td>0.1.*</td><td>2.3.*</td>
+    <td><code>0.1.*</code></td><td><code>2.3.*</code></td>
+  </tr>
+  <tr>
+    <td><code>master</code></td><td><code>2.4.*</code></td>
   </tr>
 </table>
 
@@ -30,7 +33,7 @@ First of all you have to add the bundle to your `composer.json`:
 
     {
         "require": {
-            "braincrafted/symfony2cs-bundle": "0.1.*"
+            "braincrafted/symfony2cs-bundle": "dev-master"
         }
     }
 
@@ -80,8 +83,6 @@ However, things get even better if you add the script handler that is included i
     },
     ...
 
-_The `composer.json` above is based on [Symfony 2.3.*](https://github.com/symfony/symfony-standard/blob/2.3/composer.json)._
-
 
 Usage
 -----

Resources/config/services.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" ?>
+
+<container xmlns="http://symfony.com/schema/dic/services"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
+
+    <parameters>
+        <parameter key="bc_symfony2_coding_standard.command.install.class">Bc\Bundle\Symfony2CodingStandardBundle\Command\InstallSymfony2CodingStandardCommand</parameter>
+    </parameters>
+
+    <services>
+        <service id="bc_symfony2_coding_standard.command.install" class="%bc_symfony2_coding_standard.command.install.class%">
+            <argument>%kernel.root_dir%</argument>
+            <tag name="console.command" />
+        </service>
+    </services>
+
+</container>

composer.json

@@ -3,9 +3,10 @@
     "license":     "MIT",
     "type":        "symfony-bundle",
     "require": {
-        "symfony/symfony": "2.3.0"
+        "symfony/symfony": "~2.4"
     },
     "require-dev": {
         "squizlabs/php_codesniffer": "1.4.*"
-    }
+    },
+    "minimum-stability": "beta"
 }