Skip to content

Issues to flesh out and open / Draft list of issues to detail and formalize #109

Description

@simonwacker

infrastructure

  • add GNU Make targets to gpg.mk key for GnuPG key management

frontend (Next.JS)

  • add forms, in particular, add user interface flow for creating data entries, adding resources, uploading files for resources, adding access policies, and publishing data (and maybe retracting it later on)
  • add management buttons and forms to data pages etc.
  • add resources overview pages (with information and filter about/of publishing state and whether it has a file)
  • DataSummary: add user who added the data entry
  • Logging out via Logout button does not reload the frontend (it thus appears as if the user were still logged-in)
  • tell user when data has been held back due to access policy restrictions on individual data pages and on overview pages

backend (.NET Core)

  • extend HotChocolate with AllowNot (similar to AllowAnd and AllowOr)
  • cross-database data reference: either specify which resource or auto-discover it using its data format or specify hash value instead of timestamp and use that hash value to pick the resource. For example, for applied methods it is unclear to which resource it was applied if there are multiple.
  • in addDataApproval mutation try various whit space options and choose the one that works (\n, \n\r, eof, ...)
  • upload file via POST request to /api/resources/...: improve OpenAPI specification
  • download file for access policed files, for example via https://www.local.solarbuildingenvelopes.com:7501/api/resources/019ebd26-ae17-7b8f-85ba-5ffdee711395.json, only works when clicking on a link in the frontend, but not when entering the URL directly in the web browser, because of if (AuthenticationHelpers.IsSameOriginOrReferer(httpContext.Request)) in AuthenticationHandler (in the latter case origin and referer are both null)
  • add user/institution to AuditableEntity (for *Data.cs we already store the userId of the currentUser)
  • file upload: check consistency between file type and data format media type.
  • mutation to update domain specific data like type and subtype of optical data
  • ExtractIntegralValueFromFile.cs
  • add navigation property from owned types to owner for example in *Approval.cs and also in the corresponding *FilterType. See https://learn.microsoft.com/en-us/ef/core/modeling/owned-entities
  • UpdateResponseApprovalsAsync can result in the error The DataLoaderScope has an inconsistent state due to the parallelism used there together with using IRequestExecutor (this was not a problem when I worked with HTTP POST requests to do the GraphQL query) --- is this still the case even though by now we use IRequestExecutorProvider to create different IRequestExecutors for each?
  • colorRenderingIndex: support property "raOutIn"
  • return complete integral value structure as in opticalData.json schema via GraphQL (instead of nearnormalHemisphercialVisibleTransmitt...)
  • switch between authorization modes: only database operator or anyone for their own components or both (have table with institutions that are allowed to add data for their components) and/or allow adding pending data sets for everyone and ask for verification by database owners
  • Validate JSON with JSON Schema in Methods as a Service: Use .NET's native JSON Schema support once it is implemented #3
  • Add simple queries for method calculations, for example, calculateSpectralToIntegral(standard: ...), with proper return type instead of Any
  • add mutation to set integral values from inputs (currently, integral values are extracted from files on upload via POST request to /api/resources/...) --- see *Data.ExtractAndSetValuesFromFile
  • do not rollback when response approval could not be created but ask to do it later and return data set itself with payload; also use dummy approval if it is null to make sure that the GraphQL response is always non-null
  • the IGSDB has the product type MATERIAL. Should we add it to ComponentComponentType?

data(base) (PostgreSQL & EF Core)

  • add extension to existing data entries in product-data database
  • remove files that don't belong to GET resources and find resources without files
  • clean-up pending data sets created by Jo
  • when I last checked, the resources with IDs eb0e421f-4bd3-49db-9b14-8fa32ef18579 and 5d8248f3-1ee7-4c81-9f97-ce38e9b1da85 did not have associated files

See also Issues for both projects and note that similar lists exist for the metabase and machine projects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ISEFraunhofer Institute for Solar Energy Systems ISEtriageReview issue to make sure it is relevant, actionable, and has all the necessary information

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions