Don't show retracted datasets

[christoph-maurer]

https://www.solarbuildingenvelopes.com/data/hygrothermal contains 3 hygrothermal datasets which are outdated. The current datasets are provided by https://www.buildingenvelopedata-dev.c3rro.com/graphql . When I try to delete the dataset, I get the error that I can only retract the dataset. When I retract it with

mutation {
  retract01: retractData(
    input: {
      dataId: "8ba9cd57-aef8-45a3-8d61-85d81d5a7c32"
      dataKind: HYGROTHERMAL_DATA
    }
  ) {
    errors {
      code
      message
      path
    }
  }
}

I can still see it in https://www.buildingenvelopedata.org/data/hygrothermal , even when I'm logged out. When I try to delete it now with

mutation delete01 {
  deleteData(
    input: {
      dataId: "61ed36b9-0cd9-4bb1-bbbc-cec3960eae6f"
      dataKind: HYGROTHERMAL_DATA
    }
  ) {
    errors {
      code
      message
      path
    }
  }
}

I get

{
  "data": {
    "deleteData": {
      "errors": [
        {
          "code": "NOT_PENDING",
          "message": "The publishing state is not pending but RETRACTED. If it is published, you may retract the data set. A retracted data set does not show up in queries for all data.",
          "path": []
        }
      ]
    }
  }
}

Options:

• Hide retracted datasets. The best solution. Hide the 3 hygrothermal datasets and the two optical datasets from Janina.
• Delete the resources first, then try to delete the dataset.
• Allow to delete retracted datasets. Do we want that?
• Change the label from retracted to pending with psql. Then delete the pending datasets. Dirty workaround.

[christoph-maurer]

Janina wants that the optical datasets 019ef4f1-757a-7eee-832f-b3446a2f3829 and 019ef4ee-484e-7a9b-be49-0ae33e83a12f are deleted because they are duplicates.

[simonwacker]

Once data sets are published they cannot be deleted anymore. They can be retracted though, which in some sense is a soft delete. Retracted data sets should still be accessible (at least when their UUID is known). I agree that they should not show up in searches anymore. Fixed and deployed: 53e6478

Regarding deletions: That also kind of depends on whether we consider https://www.solarbuildingenvelopes.com/ to still be in beta (in the sense that its data can still come and go and it shouldn't really be used by end-users yet) or "production-ready". I also believe that it is important to keep a database clean, so if there is certainty that data has not been used outside yet and is not relied upon by a third party, then just delete it (for example in the ugly-workaround way by changing it to PENDING in the database first).

As I side note: It is possible to misuse data access policies to hide data sets from everyone (even after publication).