fix: use stj generator for trimming

Author: captainsafia

src/Models/AppSettingsJsonContext.cs

@@ -0,0 +1,13 @@
+using System.Text.Json.Serialization;
+
+namespace Nuggy.Models;
+
+[JsonSerializable(typeof(AppSettings))]
+[JsonSerializable(typeof(FeedConfiguration))]
+[JsonSerializable(typeof(List<FeedConfiguration>))]
+[JsonSourceGenerationOptions(
+    WriteIndented = true,
+    PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase)]
+public partial class AppSettingsJsonContext : JsonSerializerContext
+{
+}

src/Services/ConfigurationManager.cs

@@ -8,11 +8,6 @@ public class ConfigurationManager
     private readonly string _configDirectory;
     private readonly string _settingsFilePath;
     private AppSettings? _cachedSettings;
-    private static readonly JsonSerializerOptions jsonSerializerOptions = new()
-    {
-        WriteIndented = true,
-        PropertyNamingPolicy = JsonNamingPolicy.CamelCase
-    };
 
     public ConfigurationManager(string? homeDirectory = null)
     {
@@ -64,7 +59,7 @@ public async Task<AppSettings> LoadSettingsAsync()
         try
         {
             var json = await File.ReadAllTextAsync(_settingsFilePath);
-            _cachedSettings = JsonSerializer.Deserialize<AppSettings>(json) ?? new AppSettings();
+            _cachedSettings = JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.AppSettings) ?? new AppSettings();
             _cachedSettings.ConfigDirectory = _configDirectory;
 
             // Ensure we have at least the default NuGet feed
@@ -92,7 +87,7 @@ public async Task SaveSettingsAsync(AppSettings settings)
     {
         try
         {
-            var json = JsonSerializer.Serialize(settings, jsonSerializerOptions);
+            var json = JsonSerializer.Serialize(settings, AppSettingsJsonContext.Default.AppSettings);
             await File.WriteAllTextAsync(_settingsFilePath, json);
             _cachedSettings = settings;
         }

tests/Models/FeedConfigurationTests.cs

@@ -34,8 +34,8 @@ public void FeedConfiguration_ShouldSerializeToJson()
         };
 
         // Act
-        var json = JsonSerializer.Serialize(feed);
-        var deserialized = JsonSerializer.Deserialize<FeedConfiguration>(json);
+        var json = JsonSerializer.Serialize(feed, AppSettingsJsonContext.Default.FeedConfiguration);
+        var deserialized = JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.FeedConfiguration);
 
         // Assert
         deserialized.ShouldNotBeNull();
@@ -58,7 +58,7 @@ public void FeedConfiguration_ShouldDeserializeWithJsonPropertyNames()
         """;
 
         // Act
-        var feed = JsonSerializer.Deserialize<FeedConfiguration>(json);
+        var feed = JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.FeedConfiguration);
 
         // Assert
         feed.ShouldNotBeNull();

tests/Services/ConfigurationManagerTests.cs

@@ -59,7 +59,7 @@ public async Task LoadSettingsAsync_WhenFileExists_ShouldLoadFromFile()
             ]
         };
 
-        var json = JsonSerializer.Serialize(expectedSettings);
+        var json = JsonSerializer.Serialize(expectedSettings, AppSettingsJsonContext.Default.AppSettings);
         Directory.CreateDirectory(_testConfigDirectory);
         await File.WriteAllTextAsync(_testSettingsPath, json);
 
@@ -99,7 +99,7 @@ public async Task SaveSettingsAsync_ShouldSerializeAndWriteToFile()
         var writtenContent = await File.ReadAllTextAsync(_testSettingsPath);
         writtenContent.ShouldNotBeNull();
 
-        var deserializedSettings = JsonSerializer.Deserialize<AppSettings>(writtenContent);
+        var deserializedSettings = JsonSerializer.Deserialize(writtenContent, AppSettingsJsonContext.Default.AppSettings);
         deserializedSettings!.Feeds.Count.ShouldBe(1);
         deserializedSettings.Feeds[0].Name.ShouldBe("test-feed");
     }
@@ -292,7 +292,7 @@ public async Task RemoveFeedAsync_ShouldRemoveFeedFromSettings()
 
     private void SetupExistingSettings(AppSettings settings)
     {
-        var json = JsonSerializer.Serialize(settings);
+        var json = JsonSerializer.Serialize(settings, AppSettingsJsonContext.Default.AppSettings);
         Directory.CreateDirectory(_testConfigDirectory);
         File.WriteAllText(_testSettingsPath, json);
     }
@@ -301,7 +301,7 @@ private async Task<AppSettings> GetSavedSettings()
     {
         File.Exists(_testSettingsPath).ShouldBeTrue();
         var json = await File.ReadAllTextAsync(_testSettingsPath);
-        return JsonSerializer.Deserialize<AppSettings>(json)!;
+        return JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.AppSettings)!;
     }
 
     public void Dispose()

tests/Services/FeedServiceTests.cs

@@ -123,7 +123,7 @@ private async Task SetupExistingSettings(AppSettings settings)
         // Set the correct config directory for our temp location
         settings.ConfigDirectory = _testConfigDirectory;
 
-        var json = JsonSerializer.Serialize(settings);
+        var json = JsonSerializer.Serialize(settings, AppSettingsJsonContext.Default.AppSettings);
         Directory.CreateDirectory(_testConfigDirectory);
         await File.WriteAllTextAsync(_testSettingsPath, json);
 
@@ -135,7 +135,7 @@ private async Task<AppSettings> GetSavedSettings()
     {
         File.Exists(_testSettingsPath).ShouldBeTrue();
         var json = await File.ReadAllTextAsync(_testSettingsPath);
-        return JsonSerializer.Deserialize<AppSettings>(json)!;
+        return JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.AppSettings)!;
     }
 
     public void Dispose()