feat: add onViewPreChange callback #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ai-chat-components-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-ai-chat-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
annawen1
reviewed
Nov 7, 2025
annawen1
approved these changes
Nov 7, 2025
ethanwinters
force-pushed
the
on-view-pre-change
branch
from
01d286e to
b223438
Compare
annawen1
merged commit 89ba5ad
into
carbon-design-system:release/v1.2.0
19 checks passed
annawen1
pushed a commit
that referenced
this pull request
Nov 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
* chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * fix: demo launcher (#634) when going to sidebar view, we were losing launcher setting when we switch back * fix(ordered-list): list counter for safari (#637) Co-authored-by: Ethan Winters <[email protected]> * fix(option): pass in label to ensure response come back with label value (#650) * fix(option): pass in label to ensure response come back with label value * fix(dropdown): trigger at select event to ensure value is set * fix: layout properties get assigned to the right variable (#653) and with correct specificity * chore: package-lock.json * chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * feat: add onViewPreChange callback (#658) * chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * chore(release): publish [skip ci] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] - @carbon/[email protected] * chore: update versions.js file --------- Co-authored-by: carbon-bot <[email protected]> Co-authored-by: Ethan Winters <[email protected]> Co-authored-by: Anna Wen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #648 #526
On the demo site our transition is very fast so we didn't notice that the onViewChange fires when we have hidden the chat contents already. This leaves folks with longer running animation states in a place where the content is hidden before their animation completes. Added a new async friendly onViewPreChange callback to both the react and web component. This is using the already existing event for this purpose, it was just an oversight.
While I was updating the demo site to account for the change, went ahead and banged out 526 which was meant to bring the sidebar into alignment with what design expects the sidebar to do.
Testing / Reviewing
Check the docs for my language in describing the onViewChange and onViewPreChange callbacks.
In the demo site, make sure the sidebar panel animates in and out in a nice way.