Upgrade taffy

[domenkozar]

0.9.0 is out, while it looks 0.5.2 is pinned: https://github.com/ccbrown/iocraft/blob/main/packages/iocraft/Cargo.toml#L12

[ccbrown]

Unfortunately there's a drawback to this: In the latest Taffy, the TaffyTree struct is no longer Send. Upgrading would be a breaking change and would limit the usability of iocraft.

Is there a particular reason you'd like to see Taffy upgraded? Aside from updating dependencies just being good practice in general.

[domenkozar]

I've been hit by some rendering bug, you can see in TUI gif how the Evaluating first line of the terminal output gets duplicated each 10s and I'm trying to see if upgrading taffy would help.

[nicoburns]

Unfortunately there's a drawback to this: In the latest Taffy, the TaffyTree struct is no longer Send. Upgrading would be a breaking change and would limit the usability of iocraft.

I know this isn't ideal, but you could wrap the TaffyTree in a newtype wrapper and then unsafe impl Send for it. This is safe so long as you are either not using calc() (currently, if you're using TaffyTree then you're not!) or the type you are using to implement Calc is Send. You should also be able to update as far as the 0.7 series without running into this at all.

The proper fix for this is for use to be generic over the Calc type, then Taffy can directly implement Send conditionally on the Calc type being Send. DioxusLabs/taffy#855 works towards that (but may end up being too ambitious).

[nicoburns]

I've been hit by some rendering bug, you can see in TUI gif how the Evaluating first line of the terminal output gets duplicated each 10s and I'm trying to see if upgrading taffy would help.

FWIW, I doubt this is a Taffy bug: Taffy never creates additional nodes. That looks like the terminal renderer accidentally moving down a line rather than overwriting the previous one to animate.

[ccbrown]

Okay, I'm going to punt on this for now in hopes of DioxusLabs/taffy#823 being resolved by a later release of Taffy. If anyone has strong motivation for upgrading sooner, then I'll consider the unsafe wrapper.