Skip to content

Commit a7f4f32

Browse files
authored
Merge pull request #280 from cdnjs/sven/r2-metrics-file-ext
split R2 pump metrics by file extension
2 parents ce7815a + 84e3ed8 commit a7f4f32

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

functions/r2-pump/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ func Invoke(ctx context.Context, e gcp.GCSEvent) error {
133133
if err := audit.WroteR2(ctx, pkgName, version, keys, FILE_EXTENSION); err != nil {
134134
log.Printf("failed to audit: %s\n", err)
135135
}
136-
if err := metrics.NewUpdatePublishedR2(); err != nil {
136+
if err := metrics.NewUpdatePublishedR2(FILE_EXTENSION); err != nil {
137137
return errors.Wrap(err, "could not report metrics")
138138
}
139139

metrics/metrics.go

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,42 @@ var (
1919
)
2020

2121
type IncMetricPayload struct {
22-
Name string `json:"name"`
22+
Name string `json:"name"`
23+
Labels []string `json:"labels"`
2324
}
2425

2526
func NewUpdateDetected() error {
2627
return sendMetrics(&IncMetricPayload{
27-
Name: "new_update_detected",
28+
Name: "new_update_detected",
29+
Labels: make([]string, 0),
2830
})
2931
}
3032

3133
func NewUpdateProccessed() error {
3234
return sendMetrics(&IncMetricPayload{
33-
Name: "new_update_processed",
35+
Name: "new_update_processed",
36+
Labels: make([]string, 0),
3437
})
3538
}
3639

3740
func NewUpdatePublishedKV() error {
3841
return sendMetrics(&IncMetricPayload{
39-
Name: "new_update_published_kv",
42+
Name: "new_update_published_kv",
43+
Labels: make([]string, 0),
4044
})
4145
}
4246

43-
func NewUpdatePublishedR2() error {
47+
func NewUpdatePublishedR2(ext string) error {
4448
return sendMetrics(&IncMetricPayload{
45-
Name: "new_update_published_r2",
49+
Name: "new_update_published_r2",
50+
Labels: []string{ext},
4651
})
4752
}
4853

4954
func NewUpdatePublishedAlgolia() error {
5055
return sendMetrics(&IncMetricPayload{
51-
Name: "new_update_published_algolia",
56+
Name: "new_update_published_algolia",
57+
Labels: make([]string, 0),
5258
})
5359
}
5460

0 commit comments

Comments
 (0)