Properly handle unknown files in InsertLineNumbers (#28021)

Fixes an issue with CHPL_UNWIND!=none when compiling a program with
extern blocks like
`test/extern/ferguson/externblock/extern_block_primer.chpl`.


This was caused by trying to write file information for all the
functions in a program (only when `CHPL_UNWIND!=none`), including the
ones in the extern block (which have no file information). This was
causing an internal error.

The solution implemented in this PR is not specific to extern blocks,
this just adds a better default than an internal error. Future work
could add file information for extern blocks.

- [x] paratest

[Reviewed by @DanilaFe]

Author: jabraham17

compiler/CMakeLists.txt

@@ -99,6 +99,7 @@ target_include_directories(chpl PRIVATE
         ${SRC_DIR}/../build/compiler/${CHPL_COMPILER_SUBDIR} # for enabling CONFIGURED_PREFIX in configured_prefix.h
         ${SRC_DIR}/../runtime/include/encoding # support for sharing unicode support between compiler and runtime
         ${SRC_DIR}/../third-party/utf8-decoder # support for sharing unicode support between compiler and runtime
+        ${SRC_DIR}/../runtime/include/fileinfo # support for sharing line/file support between compiler and runtime
         )
 
 # all the compiler subdirectories with sources do these same things

compiler/passes/insertLineNumbers.cpp

@@ -38,6 +38,8 @@
 #include <unordered_set>
 #include <vector>
 
+#include "chpl-linefile-defs.h"
+
 namespace {
   // As a means of abbreviation.
   using Pass = InsertLineNumbers;
@@ -72,8 +74,7 @@ int Pass::addFilenameTableEntry(const std::string& name) {
 
 int Pass::getFilenameTableIndex(const std::string& name) {
   if (auto optIdx = gFilenameTable.index(name)) return *optIdx;
-  INT_FATAL("Entry not in table!");
-  return -1;
+  return CHPL_FILE_IDX_UNKNOWN;
 }
 
 const std::vector<std::string>& Pass::getFilenameTable() {
@@ -147,6 +148,7 @@ Pass::LineAndFile Pass::makeASTLine(CallExpr* call) {
 
   if (call->isResolved() &&
       call->resolvedFunction()->hasFlag(FLAG_COMMAND_LINE_SETTING)) {
+    // TODO: can this just use CHPL_FILE_IDX_COMMAND_LINE_ARG?
     // Make up pretend line numbers for errors with command line
     // configuration variables.
     Symbol* line = new_IntSymbol(0);

runtime/include/chpl-linefile-support.h

@@ -23,23 +23,12 @@
 
 #include "chpltypes.h"
 
+#include "fileinfo/chpl-linefile-defs.h"
+
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-#define CHPL_FILE_IDX_INTERNAL 1 // <internal>
-
-#define CHPL_FILE_IDX_COMMAND_LINE -1     // (command-line)
-#define CHPL_FILE_IDX_COMMAND_LINE_ARG -2 // <command-line arg>
-#define CHPL_FILE_IDX_FORK_LARGE -3       // "fork large"
-#define CHPL_FILE_IDX_MAIN_PROGRAM -4     // "main program"
-#define CHPL_FILE_IDX_UNKNOWN -5          // "<unknown>"
-#define CHPL_FILE_IDX_IDLE_TASK -6        // "|idle|"
-#define CHPL_FILE_IDX_COMM_TASK -7        // "<comm thread>"
-#define CHPL_FILE_IDX_MAIN_TASK -8        // "<main task>"
-#define CHPL_FILE_IDX_ON_BODY_TASK -9     // "on-body task"
-#define CHPL_FILE_IDX_SAVED_FILENAME -10  // variable, see below
-
 // chpl_saveFilename stores the passed in char*, subsequent calls to
 // chpl_lookupFilename(CHPL_FILE_IDX_SAVED_FILENAME) will return that stored
 // pointer. CHPL_FILE_IDX_SAVED_FILENAME may only be used while the original

runtime/include/fileinfo/chpl-linefile-defs.h

@@ -0,0 +1,46 @@
+/*
+ * Copyright 2020-2025 Hewlett Packard Enterprise Development LP
+ * Copyright 2004-2019 Cray Inc.
+ * Other additional copyright holders may be indicated within.
+ *
+ * The entirety of this work is licensed under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ *
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#ifndef _chpl_linefile_defs_h_
+#define _chpl_linefile_defs_h_
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+enum chpl_file_idx_t {
+  CHPL_FILE_IDX_INTERNAL = 1, // <internal>
+  CHPL_FILE_IDX_COMMAND_LINE = -1,     // (command-line)
+  CHPL_FILE_IDX_COMMAND_LINE_ARG = -2, // <command-line arg>
+  CHPL_FILE_IDX_FORK_LARGE = -3,       // "fork large"
+  CHPL_FILE_IDX_MAIN_PROGRAM = -4,     // "main program"
+  CHPL_FILE_IDX_UNKNOWN = -5,          // "<unknown>"
+  CHPL_FILE_IDX_IDLE_TASK = -6,        // "|idle|"
+  CHPL_FILE_IDX_COMM_TASK = -7,        // "<comm thread>"
+  CHPL_FILE_IDX_MAIN_TASK = -8,        // "<main task>"
+  CHPL_FILE_IDX_ON_BODY_TASK = -9,     // "on-body task"
+  CHPL_FILE_IDX_SAVED_FILENAME = -10,  // variable, see chpl-linefile-support.h
+};
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif // _chpl_linefile_defs_h_