Replace c_ptrTo array workarounds with c_addrOf
#26175
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riftEmber
changed the title
c_ptrTo array workarounds with c_addrOfc_ptrTo array workarounds with c_addrOf
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
from
083f2ef to
41805a2
Compare
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
from
41805a2 to
460e0f6
Compare
Contributor
Author
|
This currently fails gasnet paratest because apparently we take arrays of addresses on other locales; see https://github.com/Cray/chapel-private/issues/6587#issuecomment-2450278329. |
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
from
460e0f6 to
554cd4a
Compare
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
2 times, most recently
from
58ee116 to
9d60cf1
Compare
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
14 times, most recently
from
aa601c5 to
d5ebbcb
Compare
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
remove-cptr-workarounds
branch
from
d5ebbcb to
9772374
Compare
arifthpe
changed the title
c_ptrTo array workarounds with c_addrOfc_ptrTo array workarounds with c_addrOf
Collaborator
|
Closing in favor of #27866 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace instances of
c_pointer_returnwithc_addrOfin module code (besides CTypes itself), and allow passing domains toc_addrOf.There are a few instances in module code where
c_pointer_returnis used directly rather thanc_ptrToto avoid its special behavior on arrays. However, we now havec_addrOfas an alternative that has no such special behavior that should be used instead. This PR updates all instances to usec_addrOfinstead of workarounds.Resolves https://github.com/Cray/chapel-private/issues/6587.
[reviewer info placeholder]
Testing: