Skip to content

Commit 58ff96e

Browse files
authored
Merge pull request #59 from cloudkite-io/update-monitoring-vpa
fix(monitoring): ensure vpa mode is quoted & make minReplicas optional
2 parents 732e56f + 4a8d387 commit 58ff96e

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

monitoring/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: monitoring
33
description: Helm chart for Prometheus
44
type: application
5-
version: 0.4.1
5+
version: 0.4.2
66
dependencies:
77
- name: kube-prometheus-stack
88
version: 69.8.2

monitoring/templates/vpa.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@ spec:
1010
kind: {{ $vpaAppConfig.kind }}
1111
name: {{ if eq $vpaAppName "prometheus" }}{{ $vpaAppName }}-{{ template "monitoring.fullname" $ }}-{{ $vpaAppName }}{{ else }}{{ template "monitoring.fullname" $ }}-{{ $vpaAppName }}{{- end }}
1212
updatePolicy:
13-
updateMode: {{ $vpaAppConfig.mode | default "Auto" }}
14-
minReplicas: {{ $vpaAppConfig.minReplicas | default "1" }}
13+
updateMode: {{ $vpaAppConfig.mode | default "Off" | quote }}
14+
{{ if $vpaAppConfig.minReplicas }}
15+
minReplicas: {{ $vpaAppConfig.minReplicas }}
16+
{{- end }}
1517
---
1618
{{- end }}
1719
{{- end }}

monitoring/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,3 @@ vpaApps:
125125
kind: Deployment
126126
prometheus-node-exporter:
127127
kind: DaemonSet
128-
minReplicas: 2

0 commit comments

Comments
 (0)