fix(adk): improve review-and-edit tool call wrapper response

shentongmartin · shentongmartin · commit f596303465cf · 2025-11-14T15:02:52.000+08:00
Change-Id: I22b30575551f3f9d9b10a65ce11bcc2a92199a0b
diff --git a/adk/common/tool/review_edit_wrapper.go b/adk/common/tool/review_edit_wrapper.go
@@ -104,7 +104,12 @@ func (i InvokableReviewEditTool) InvokableRun(ctx context.Context, argumentsInJS
 	}
 
 	if result.EditedArgumentsInJSON != nil {
-		return i.InvokableTool.InvokableRun(ctx, *result.EditedArgumentsInJSON, opts...)
+		res, err := i.InvokableTool.InvokableRun(ctx, *result.EditedArgumentsInJSON, opts...)
+		if err != nil {
+			return "", err
+		}
+		return fmt.Sprintf("after presenting the tool call info to the user, the user explilcitly changed tool call arguments to %s. Tool called, final result: %s",
+			*result.EditedArgumentsInJSON, res), nil
 	}
 
 	return "", fmt.Errorf("invalid review result for tool '%s'", toolInfo.Name)

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,12 @@ func (i InvokableReviewEditTool) InvokableRun(ctx context.Context, argumentsInJS`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`if result.EditedArgumentsInJSON != nil {`
`107`		`- return i.InvokableTool.InvokableRun(ctx, *result.EditedArgumentsInJSON, opts...)`
	`107`	`+ res, err := i.InvokableTool.InvokableRun(ctx, *result.EditedArgumentsInJSON, opts...)`
	`108`	`+ if err != nil {`
	`109`	`+ return "", err`
	`110`	`+ }`
	`111`	`+ return fmt.Sprintf("after presenting the tool call info to the user, the user explilcitly changed tool call arguments to %s. Tool called, final result: %s",`
	`112`	`+ *result.EditedArgumentsInJSON, res), nil`
`108`	`113`	`}`
`109`	`114`
`110`	`115`	`return "", fmt.Errorf("invalid review result for tool '%s'", toolInfo.Name)`