update after review

Signed-off-by: lou <[email protected]>

Author: 27149chen

pkg/synchromanager/clustersynchro/resource_negotiator.go

@@ -22,7 +22,7 @@ import (
 )
 
 // excludedInternalResources is a list of internal resources that are not synchronized
-// if the feature gate SkipSyncInternalResources is enabled.
+// if the feature gate SkipSyncLeases is enabled.
 var excludedInternalResources = sets.NewString(
 	"leases.coordination.k8s.io",
 )
@@ -94,7 +94,7 @@ func (negotiator *ResourceNegotiator) NegotiateSyncResources(syncResources []clu
 		for _, resource := range groupResources.Resources {
 			syncGR := schema.GroupResource{Group: groupResources.Group, Resource: resource}
 
-			if clusterpediafeature.FeatureGate.Enabled(features.SkipSyncInternalResources) {
+			if clusterpediafeature.FeatureGate.Enabled(features.SkipSyncLeases) {
 				// skip internal resources
 				if excludedInternalResources.Has(syncGR.String()) {
 					klog.InfoS("Skip resource sync", "cluster", negotiator.name, "resource", resource, "reason", "internal resource")

pkg/synchromanager/features/features.go

@@ -55,20 +55,19 @@ const (
 	// alpha: v0.8.0
 	ForcePaginatedListForResourceSync featuregate.Feature = "ForcePaginatedListForResourceSync"
 
-	// StreamHandlePaginatedListForResourceSync is a featuSkipSyncInternalResourcese gate for ResourceSync's reflector to handle echo paginated resources,
+	// StreamHandlePaginatedListForResourceSync is a feature gate for ResourceSync's reflector to handle echo paginated resources,
 	// resources within a pager will be processed as soon as possible instead of waiting until all resources are pulled before calling the ResourceHandler.
 	//
 	// owner: @iceber
 	// alpha: v0.8.0
 	StreamHandlePaginatedListForResourceSync featuregate.Feature = "StreamHandlePaginatedListForResourceSync"
 
-	// SkipSyncInternalResources is a feature gate for the ClusterSynchro to skip syncing some internal resources,
+	// SkipSyncLeases is a feature gate for the ClusterSynchro to skip syncing leases.coordination.k8s.io,
 	// if you enable this feature, these resources will not be synced no matter what `syncResources` are defined.
-	// Currently, the following resources are skipped: leases.coordination.k8s.io
 	//
 	// owner: @27149chen
 	// alpha: v0.8.0
-	SkipSyncInternalResources featuregate.Feature = "SkipSyncInternalResources"
+	SkipSyncLeases featuregate.Feature = "SkipSyncLeases"
 )
 
 func init() {
@@ -86,5 +85,5 @@ var defaultClusterSynchroManagerFeatureGates = map[featuregate.Feature]featurega
 
 	ForcePaginatedListForResourceSync:        {Default: false, PreRelease: featuregate.Alpha},
 	StreamHandlePaginatedListForResourceSync: {Default: false, PreRelease: featuregate.Alpha},
-	SkipSyncInternalResources:                {Default: false, PreRelease: featuregate.Alpha},
+	SkipSyncLeases:                           {Default: false, PreRelease: featuregate.Alpha},
 }