Skip to content

Commit 73d91c5

Browse files
authored
remove msrv check (#21)
1 parent 4c4ec8d commit 73d91c5

File tree

2 files changed

+43
-43
lines changed

2 files changed

+43
-43
lines changed

.github/workflows/check.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -94,23 +94,23 @@ jobs:
9494
# --feature-powerset runs for every combination of features
9595
- name: cargo hack
9696
run: cargo hack --feature-powerset check
97-
msrv:
98-
# check that we can build using the minimal rust version that is specified by this crate
99-
runs-on: ubuntu-latest
100-
# we use a matrix here just because env can't be used in job names
101-
# https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
102-
strategy:
103-
matrix:
104-
# Rust 2024 Edition MSRV
105-
msrv: ["1.85.0"]
106-
name: ubuntu / ${{ matrix.msrv }}
107-
steps:
108-
- uses: actions/checkout@v5
109-
with:
110-
submodules: true
111-
- name: Install ${{ matrix.msrv }}
112-
uses: dtolnay/rust-toolchain@master
113-
with:
114-
toolchain: ${{ matrix.msrv }}
115-
- name: cargo +${{ matrix.msrv }} check
116-
run: cargo check
97+
# msrv:
98+
# # check that we can build using the minimal rust version that is specified by this crate
99+
# runs-on: ubuntu-latest
100+
# # we use a matrix here just because env can't be used in job names
101+
# # https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability
102+
# strategy:
103+
# matrix:
104+
# # Rust 2024 Edition MSRV
105+
# msrv: ["1.85.0"]
106+
# name: ubuntu / ${{ matrix.msrv }}
107+
# steps:
108+
# - uses: actions/checkout@v5
109+
# with:
110+
# submodules: true
111+
# - name: Install ${{ matrix.msrv }}
112+
# uses: dtolnay/rust-toolchain@master
113+
# with:
114+
# toolchain: ${{ matrix.msrv }}
115+
# - name: cargo +${{ matrix.msrv }} check
116+
# run: cargo check

.github/workflows/test.yml

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -45,28 +45,28 @@ jobs:
4545
# https://github.com/rust-lang/cargo/issues/6669
4646
- name: cargo test --doc
4747
run: cargo test --locked --all-features --doc
48-
minimal:
49-
# This action chooses the oldest version of the dependencies permitted by Cargo.toml to ensure
50-
# that this crate is compatible with the minimal version that this crate and its dependencies
51-
# require. This will pickup issues where this create relies on functionality that was introduced
52-
# later than the actual version specified (e.g., when we choose just a major version, but a
53-
# method was added after this version).
54-
runs-on: ubuntu-latest
55-
name: ubuntu / stable / minimal-versions
56-
steps:
57-
- uses: actions/checkout@v5
58-
with:
59-
submodules: true
60-
- name: Install stable
61-
uses: dtolnay/rust-toolchain@stable
62-
- name: Install nightly for -Z direct-minimal-versions
63-
uses: dtolnay/rust-toolchain@nightly
64-
- name: rustup default stable
65-
run: rustup default stable
66-
- name: cargo update -Z direct-minimal-versions
67-
run: cargo +nightly update -Z direct-minimal-versions
68-
- name: cargo test
69-
run: cargo test --locked --all-features --all-targets
48+
# minimal:
49+
# # This action chooses the oldest version of the dependencies permitted by Cargo.toml to ensure
50+
# # that this crate is compatible with the minimal version that this crate and its dependencies
51+
# # require. This will pickup issues where this create relies on functionality that was introduced
52+
# # later than the actual version specified (e.g., when we choose just a major version, but a
53+
# # method was added after this version).
54+
# runs-on: ubuntu-latest
55+
# name: ubuntu / stable / minimal-versions
56+
# steps:
57+
# - uses: actions/checkout@v5
58+
# with:
59+
# submodules: true
60+
# - name: Install stable
61+
# uses: dtolnay/rust-toolchain@stable
62+
# - name: Install nightly for -Z direct-minimal-versions
63+
# uses: dtolnay/rust-toolchain@nightly
64+
# - name: rustup default stable
65+
# run: rustup default stable
66+
# - name: cargo update -Z direct-minimal-versions
67+
# run: cargo +nightly update -Z direct-minimal-versions
68+
# - name: cargo test
69+
# run: cargo test --locked --all-features --all-targets
7070
os-check:
7171
# run cargo test on mac and windows
7272
runs-on: ${{ matrix.os }}
@@ -138,4 +138,4 @@ jobs:
138138
# with:
139139
# fail_ci_if_error: true
140140
# token: ${{ secrets.CODECOV_TOKEN }}
141-
# env_vars: OS,RUST
141+
# env_vars: OS,RUST

0 commit comments

Comments
 (0)