refactor: split core into cli, storage and vscode modules

`core/` mixed four concerns. Give each its own home:

- `cli/`: CLI binary lifecycle and invocation (`cliManager`,
  `cliBinary`, `binaryLock`, `downloadProgress`, `cliExec`,
  `cliCredentialManager`)
- `storage/`: persisted state (`secretsManager`, `mementoManager`,
  `pathResolver`)
- `vscode/`: typed wrappers over VS Code registration APIs
  (`commandManager`, `contextManager`, and `proposed`, formerly
  `src/vscodeProposed.ts`)
- `container.ts` moves next to `extension.ts` as the composition root,
  and `sessionId` joins the other OTel-format ids in `telemetry/ids`

Author: EhabY

.oxlintrc.jsonc

@@ -267,7 +267,7 @@
 			}
 		},
 		{
-			"files": ["src/core/contextManager.ts", "src/core/commandManager.ts"],
+			"files": ["src/vscode/contextManager.ts", "src/vscode/commandManager.ts"],
 			"rules": {
 				"eslint-js/no-restricted-syntax": "off"
 			}

src/announcements/manager.ts

@@ -16,9 +16,9 @@ import {
 import { AnnouncementsPreview } from "./preview";
 
 import type { CoderApi } from "../api/coderApi";
-import type { MementoManager } from "../core/mementoManager";
 import type { SessionState } from "../deployment/sessionStore";
 import type { Logger } from "../logging/logger";
+import type { MementoManager } from "../storage/mementoManager";
 
 /** Background poll interval; sign-in and manual refresh happen immediately either way. */
 export const REFRESH_INTERVAL_MS = 30 * 60 * 1000;

src/api/authInterceptor.ts

@@ -8,10 +8,10 @@ import { HttpStatusCode } from "./httpStatusCode";
 
 import type * as vscode from "vscode";
 
-import type { ServiceContainer } from "../core/container";
-import type { SecretsManager } from "../core/secretsManager";
+import type { ServiceContainer } from "../container";
 import type { Logger } from "../logging/logger";
 import type { OAuthSessionManager } from "../oauth/sessionManager";
+import type { SecretsManager } from "../storage/secretsManager";
 
 import type { CoderApi } from "./coderApi";
 

src/api/coderApi.ts

@@ -12,7 +12,6 @@ import {
 	CONFIG_CHANGE_DEBOUNCE_MS,
 	watchConfigurationChanges,
 } from "../configWatcher";
-import { sessionId } from "../core/sessionId";
 import { ClientCertificateError } from "../error/clientCertificateError";
 import { toError } from "../error/normalize";
 import { ServerCertificateError } from "../error/serverCertificateError";
@@ -33,6 +32,7 @@ import {
 import { AuthConfigTracker } from "../settings/authConfig";
 import { getHeaderCommand } from "../settings/headers";
 import { readHttpClientLogLevel } from "../settings/logger";
+import { sessionId } from "../telemetry/ids";
 import {
 	NOOP_TELEMETRY_REPORTER,
 	type TelemetryReporter,

src/core/binaryLock.ts src/cli/binaryLock.tssrc/core/binaryLock.ts renamed to src/cli/binaryLock.ts

@@ -3,7 +3,7 @@ import * as lockfile from "proper-lockfile";
 import * as vscode from "vscode";
 
 import { type Logger } from "../logging/logger";
-import { vscodeProposed } from "../vscodeProposed";
+import { vscodeProposed } from "../vscode/proposed";
 
 import * as downloadProgress from "./downloadProgress";
 

src/core/cliBinary.ts src/cli/cliBinary.tssrc/core/cliBinary.ts renamed to src/cli/cliBinary.ts

@@ -25,10 +25,9 @@ import { version } from "./cliExec";
 import type { WorkspaceConfiguration } from "vscode";
 
 import type { Logger } from "../logging/logger";
+import type { PathResolver } from "../storage/pathResolver";
 import type { Span } from "../telemetry/span";
 
-import type { PathResolver } from "./pathResolver";
-
 const execFileAsync = promisify(execFile);
 
 const EXEC_TIMEOUT_MS = 60_000;

src/core/cliCredentialManager.ts src/cli/cliCredentialManager.tssrc/core/cliCredentialManager.ts renamed to src/cli/cliCredentialManager.ts

@@ -26,7 +26,7 @@ import {
 import { showStoreCredentialsError } from "../login/credentials";
 import * as pgp from "../pgp";
 import { withCancellableProgress, withOptionalProgress } from "../ui/progress";
-import { vscodeProposed } from "../vscodeProposed";
+import { vscodeProposed } from "../vscode/proposed";
 
 import { BinaryLock } from "./binaryLock";
 import * as cliBinary from "./cliBinary";
@@ -37,11 +37,11 @@ import type { Api } from "coder/site/src/api/api";
 import type { IncomingMessage } from "node:http";
 
 import type { Logger } from "../logging/logger";
+import type { PathResolver } from "../storage/pathResolver";
 import type { TelemetryService } from "../telemetry/service";
 import type { Span } from "../telemetry/span";
 
 import type { CliCredentialManager } from "./cliCredentialManager";
-import type { PathResolver } from "./pathResolver";
 
 type ResolvedBinary =
 	| { binPath: string; stat: Stats; source: "file_path" | "directory" }