refactor: replace util modules with topic-named modules

Remove `src/util.ts` and the `src/util/` folder. Helpers with a single
owner move next to it, and shared helpers move into topic folders:

- `fs/`: `atomicWrite`, `fileCleanup`, `expandPath`
- `text/`: `lowercase`, `countSubstring`, `shellEscape`
- `ui/`: `progress`, `prompts`, `statusBar`
- `uri/url`, `remote/authority`, `remote/sshLogPort`, `telemetry/date`,
  `login/credentials`, `webviews/workspaces/poller`

Split or rename the feature-level grab-bag files by what they hold:

- `api/api-helper` into `error/normalize` (`errToStr`), `deployment/roles`,
  `workspace/agents`, `workspace/labels` and `api/agentMetadata`
- `api/utils` to `api/httpAgent`, `api/agentMetadataHelper` to
  `api/agentMetadata`, `core/cliUtils` to `core/cliBinary`
- `error/errorUtils` into `error/abort` and `error/normalize`
- `logging/utils` into `logging/ids` and `logging/formatters`
- `oauth/utils` into `oauth/pkce`, `oauth/tokens` and `oauth/constants`
- `websocket/utils` into `websocket/encoding` and `websocket/handshakeError`

Tests move and split to mirror the new layout. No behavior changes.

Author: EhabY

src/announcements/manager.ts

@@ -1,9 +1,9 @@
 import * as vscode from "vscode";
 
-import { errToStr } from "../api/api-helper";
-import { withProgress } from "../progress";
+import { errToStr } from "../error/normalize";
 import { areNotificationsDisabled } from "../settings/notifications";
-import { createStatusBarItem } from "../util/statusBar";
+import { withProgress } from "../ui/progress";
+import { createStatusBarItem } from "../ui/statusBar";
 
 import {
 	type Announcement,

src/api/agentMetadataHelper.ts src/api/agentMetadata.tssrc/api/agentMetadataHelper.ts renamed to src/api/agentMetadata.ts

@@ -1,16 +1,32 @@
 import { type WorkspaceAgent } from "coder/site/src/api/typesGenerated";
 import * as vscode from "vscode";
+import { z } from "zod";
 
+import { errToStr } from "../error/normalize";
 import { WebSocketCloseCode } from "../websocket/codes";
 
-import {
-	type AgentMetadataEvent,
-	AgentMetadataEventSchemaArray,
-	errToStr,
-} from "./api-helper";
-
 import type { UnidirectionalStream } from "../websocket/eventStreamConnection";
 
+export const AgentMetadataEventSchema = z.object({
+	result: z.object({
+		collected_at: z.string(),
+		age: z.number(),
+		value: z.string(),
+		error: z.string(),
+	}),
+	description: z.object({
+		display_name: z.string(),
+		key: z.string(),
+		script: z.string(),
+		interval: z.number(),
+		timeout: z.number(),
+	}),
+});
+
+export const AgentMetadataEventSchemaArray = z.array(AgentMetadataEventSchema);
+
+export type AgentMetadataEvent = z.infer<typeof AgentMetadataEventSchema>;
+
 export interface AgentMetadataClient {
 	watchAgentMetadata(
 		agentId: string,

src/api/api-helper.ts

@@ -2,7 +2,7 @@ import { type AxiosError, isAxiosError } from "axios";
 
 import { AuthTelemetry } from "../instrumentation/auth";
 import { OAuthError } from "../oauth/errors";
-import { toSafeHost } from "../util/uri";
+import { toSafeHost } from "../uri/url";
 
 import { HttpStatusCode } from "./httpStatusCode";
 

src/api/authInterceptor.ts

@@ -14,10 +14,11 @@ import {
 } from "../configWatcher";
 import { sessionId } from "../core/sessionId";
 import { ClientCertificateError } from "../error/clientCertificateError";
-import { toError } from "../error/errorUtils";
+import { toError } from "../error/normalize";
 import { ServerCertificateError } from "../error/serverCertificateError";
 import { getHeaders } from "../headers";
 import { EventStreamLogger } from "../logging/eventStreamLogger";
+import { sizeOf } from "../logging/formatters";
 import {
 	createRequestMeta,
 	logError,
@@ -29,7 +30,6 @@ import {
 	type RequestConfigWithMeta,
 	type HttpClientLogLevel,
 } from "../logging/types";
-import { sizeOf } from "../logging/utils";
 import { AuthConfigTracker } from "../settings/authConfig";
 import { getHeaderCommand } from "../settings/headers";
 import { readHttpClientLogLevel } from "../settings/logger";
@@ -38,6 +38,7 @@ import {
 	type TelemetryReporter,
 } from "../telemetry/reporter";
 import { WebSocketCloseCode } from "../websocket/codes";
+import { handshakeStatus } from "../websocket/handshakeError";
 import {
 	OneWayWebSocket,
 	type OneWayWebSocketInit,
@@ -49,16 +50,15 @@ import {
 	type SocketFactory,
 } from "../websocket/reconnectingWebSocket";
 import { SseConnection } from "../websocket/sseConnection";
-import { handshakeStatus } from "../websocket/utils";
 
 import { getRefreshCommand, refreshCertificates } from "./certificateRefresh";
+import { createHttpAgent } from "./httpAgent";
 import { HttpStatusCode } from "./httpStatusCode";
 import {
 	parseApiResponse,
 	VALIDATED_RESPONSES,
 	type ValidatedMethods,
 } from "./responseValidation";
-import { createHttpAgent } from "./utils";
 
 import type {
 	GetInboxNotificationResponse,

src/api/coderApi.ts

@@ -2,7 +2,7 @@ import fs from "node:fs/promises";
 import { ProxyAgent } from "proxy-agent";
 import { type WorkspaceConfiguration } from "vscode";
 
-import { expandPath } from "../util";
+import { expandPath } from "../fs/expandPath";
 
 import { getProxyForUrl, joinNoProxy } from "./proxy";
 

src/api/utils.ts src/api/httpAgent.tssrc/api/utils.ts renamed to src/api/httpAgent.ts

@@ -1,9 +1,9 @@
 import { spawn } from "node:child_process";
 import * as vscode from "vscode";
 
+import { errToStr } from "../error/normalize";
 import { getGlobalFlags, type CliAuth } from "../settings/cli";
-
-import { errToStr, createWorkspaceIdentifier } from "./api-helper";
+import { createWorkspaceIdentifier } from "../workspace/labels";
 
 import type { Api } from "coder/site/src/api/api";
 import type {

src/api/workspace.ts

@@ -1,8 +1,8 @@
 import * as vscode from "vscode";
 import { ZodError } from "zod";
 
-import { toError } from "../error/errorUtils";
-import { withCancellableProgress, type ProgressContext } from "../progress";
+import { toError } from "../error/normalize";
+import { withCancellableProgress, type ProgressContext } from "../ui/progress";
 import { openJsonBeside } from "../webviews/openJson";
 
 import type { DiagnosticTrace } from "../instrumentation/diagnostics";

src/command/diagnosticFlow.ts

@@ -4,15 +4,11 @@ import * as path from "node:path";
 import * as semver from "semver";
 import * as vscode from "vscode";
 
-import {
-	createWorkspaceIdentifier,
-	extractAgents,
-	workspaceStatusLabel,
-} from "./api/api-helper";
 import { runDiagnosticCli } from "./command/diagnosticFlow";
 import * as cliExec from "./core/cliExec";
+import { raceWithAbort } from "./error/abort";
 import { CertificateError } from "./error/certificateError";
-import { raceWithAbort, toError } from "./error/errorUtils";
+import { toError } from "./error/normalize";
 import { type CliFeatureSet, cliFeatureSet } from "./featureSet";
 import {
 	AuthTelemetry,
@@ -34,11 +30,15 @@ import {
 	type WorkspacePickerSource,
 } from "./instrumentation/workspaceOpen";
 import {
-	reportElapsedProgress,
-	withCancellableProgress,
-	withProgress,
-} from "./progress";
-import { maybeAskAgent, maybeAskUrl } from "./promptUtils";
+	LegacyEditorId,
+	currentEditorId,
+	hostEditorId,
+	isRemoteAuthorityCompatible,
+	parseRemoteAuthority,
+	sshHostOf,
+	toLegacyAuthority,
+	toRemoteAuthority,
+} from "./remote/authority";
 import {
 	RECOMMENDED_SSH_SETTINGS,
 	applySettingOverrides,
@@ -51,19 +51,20 @@ import {
 } from "./supportBundle/remoteServerDataPath";
 import { runExportTelemetryCommand } from "./telemetry/export/command";
 import {
-	LegacyEditorId,
-	currentEditorId,
-	hostEditorId,
-	isRemoteAuthorityCompatible,
-	parseRemoteAuthority,
-	sshHostOf,
-	toLegacyAuthority,
-	toRemoteAuthority,
-} from "./util/authority";
-import { openInBrowser, toSafeHost } from "./util/uri";
+	reportElapsedProgress,
+	withCancellableProgress,
+	withProgress,
+} from "./ui/progress";
+import { maybeAskAgent, maybeAskUrl } from "./ui/prompts";
+import { openInBrowser, toSafeHost } from "./uri/url";
 import { vscodeProposed } from "./vscodeProposed";
 import { parseNetcheckReport } from "./webviews/netcheck/types";
 import { parseSpeedtestResult } from "./webviews/speedtest/types";
+import { extractAgents } from "./workspace/agents";
+import {
+	createWorkspaceIdentifier,
+	workspaceStatusLabel,
+} from "./workspace/labels";
 import {
 	AgentTreeItem,
 	type OpenableTreeItem,