Move task creation into form_valid

Author: SebastianKapunkt

joeflow/views.py

@@ -56,19 +56,22 @@ def get_task(self):
         except KeyError:
             return models.Task(name=self.name, type=models.Task.HUMAN)
 
-    def get_object(self, queryset=None):
-        task = self.get_task()
-        return task.workflow
-
-    @transaction.atomic
-    def post(self, request, *args, **kwargs):
-        response = super().post(request, *args, **kwargs)
+    def next_task(self):
         task = self.get_task()
         task.workflow = self.model._base_manager.get(
             pk=self.model._base_manager.get(pk=self.object.pk)
         )
-        task.finish(request.user)
+        task.finish(self.request.user)
         task.start_next_tasks()
+
+    def get_object(self, queryset=None):
+        task = self.get_task()
+        return task.workflow
+
+    @transaction.atomic
+    def form_valid(self, form):
+        response = super().form_valid(form)
+        self.next_task()
         return response
 
 

tests/test_views.py

@@ -0,0 +1,17 @@
+from django.urls import reverse
+
+from .testapp import models
+
+
+class TestTaskViewMixin:
+    def test_create_task__form_errors(self, db, admin_client, admin_user):
+        url = reverse("shippingworkflow:checkout")
+        response = admin_client.post(
+            url, data={"shipping_address": 123, "email": "not a email"}
+        )
+        assert response.status_code == 200
+        assert response.context_data["form"].errors == {
+            "email": ["Enter a valid email address."]
+        }
+
+        assert models.Shipment.objects.count() == 0