Add ARIA focus behavior docs and focus tests - #47
tilucasoli wants to merge 1 commit into
Conversation
Introduces ARIA_FOCUS_BEHAVIOR.md detailing WAI-ARIA focus management for naked_ui components. Adds comprehensive focus behavior tests for Accordion, Button, and Checkbox. Updates NakedDialog to auto-focus the first focusable element on mount. Refines popover and textfield focus handling for ARIA compliance. Minor UI and code improvements in example and popover components.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
Closing — the library changes are superseded, and one would now regress. The tests are still worth having. The 3 library files (+44/-30) no longer apply:
The 11 focus test files (~5,200 lines) are still missing. There is no Suggested salvage: take the test cases, drop the library diff. They need updating to current APIs rather than re-deriving — though the dialog cases were written against this PR's implementation and will need adjusting to main's Thanks for the coverage; it is the part that outlived the branch. |
Description
Adds comprehensive focus behavior tests for Accordion, Button, and Checkbox. Updates NakedDialog to auto-focus the first focusable element on mount. Refines popover and textfield focus handling for ARIA compliance. Minor UI and code improvements in example and popover components.
Related Issues
#46
Checklist
Note: Updating the
pubspec.yamlandCHANGELOG.mdis not required. These are handled automatically during the release process.///).Breaking Change
Does this PR require users of the package to manually update their code?