Merge pull request #63 from confluentinc/vinnybod/fix-publishing

Add MavenPublisherTest and add closeable to HttpDownloader

Author: vinnybod

MODULE.bazel

@@ -74,6 +74,7 @@ maven.install(
         "com.google.auth:google-auth-library-oauth2-http:1.23.0",
         "com.google.cloud:google-cloud-core:2.40.0",
         "com.google.cloud:google-cloud-storage:2.40.1",
+        "com.google.code.findbugs:jsr305:3.0.2",
         "com.google.code.gson:gson:2.11.0",
         "com.google.googlejavaformat:google-java-format:1.22.0",
         "com.google.guava:guava:33.2.1-jre",
@@ -99,6 +100,7 @@ maven.install(
         "org.slf4j:jul-to-slf4j:2.0.12",
         "org.slf4j:log4j-over-slf4j:2.0.12",
         "org.slf4j:slf4j-simple:2.0.12",
+        "org.slf4j:slf4j-api:2.0.12",
         "software.amazon.awssdk:s3:2.26.12",
         "software.amazon.awssdk:sdk-core:2.26.12",
         "org.bouncycastle:bcprov-jdk15on:1.68",

private/tools/java/com/github/bazelbuild/rules_jvm_external/maven/BUILD

@@ -1,19 +1,38 @@
-load("@rules_java//java:defs.bzl", "java_binary")
+load("@rules_java//java:defs.bzl", "java_binary", "java_library")
 load("@rules_jvm_external//:defs.bzl", "artifact")
 
 java_binary(
     name = "MavenPublisher",
+    main_class = "com.github.bazelbuild.rules_jvm_external.maven.MavenPublisher",
+    visibility = ["//visibility:public"],
+    runtime_deps = [
+        artifact(
+            "org.slf4j:slf4j-simple",
+            repository_name = "rules_jvm_external_deps",
+        ),
+        ":MavenPublisherLib",
+    ],
+)
+
+java_library(
+    name = "MavenPublisherLib",
     srcs = [
         "MavenPublisher.java",
         "MavenSigning.java",
     ],
-    main_class = "com.github.bazelbuild.rules_jvm_external.maven.MavenPublisher",
-    visibility = ["//visibility:public"],
     deps = [
         "//private/tools/java/com/github/bazelbuild/rules_jvm_external",
         "//private/tools/java/com/github/bazelbuild/rules_jvm_external/resolver/netrc",
         "//private/tools/java/com/github/bazelbuild/rules_jvm_external/resolver/remote",
         "//private/tools/java/com/github/bazelbuild/rules_jvm_external/resolver/ui",
+        artifact(
+            "org.slf4j:slf4j-api",
+            repository_name = "rules_jvm_external_deps",
+        ),
+        artifact(
+            "com.google.code.findbugs:jsr305",
+            repository_name = "rules_jvm_external_deps",
+        ),
         artifact(
             "software.amazon.awssdk:sdk-core",
             repository_name = "rules_jvm_external_deps",
@@ -69,3 +88,23 @@ java_binary(
         ),
     ],
 )
+
+java_test(
+    name = "MavenPublisherTest",
+    srcs = ["MavenPublisherTest.java"],
+    env = {
+    },
+    runtime_deps = [
+        artifact(
+            "org.slf4j:slf4j-simple",
+            repository_name = "rules_jvm_external_deps",
+        ),
+    ],
+    deps = [
+        ":MavenPublisherLib",
+        artifact(
+            "junit:junit",
+            repository_name = "regression_testing_coursier",
+        ),
+    ],
+)