go module updates (gvisor and tcpproxy) #554
Open
+5,943
−1,774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/hold |
cfergeau
force-pushed
the
update-gvisor
branch
from
d4d5922 to
0b6a096
Compare
This updates gvisor.dev/gvisor to the release-20250820.0 tag. There was one minor API change, see google/gvisor@496c218 Signed-off-by: Christophe Fergeau <[email protected]>
This will help verify containers#428 is really fixed. Signed-off-by: Christophe Fergeau <[email protected]>
The bug which made us use our own tcpproxy copy no longer seems to occur. It was most likely related to inetaf/tcpproxy@48c7e53 This reverts c315e61. This fixes containers#387 Signed-off-by: Christophe Fergeau <[email protected]>
cfergeau
force-pushed
the
update-gvisor
branch
from
0b6a096 to
ac1013c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates gvisor to one of the latest releases.
This allows to fix one long standing bug with pings to unknown addresses
not failing.
This also switches back to github.com/inetaf/tcpproxy as the bug we were
seeing has been fixed upstream.