replace hard coded dependency on gcc #434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppergrayxyz
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
peppergrayxyz
force-pushed
the
make_cc
branch
from
c45258d to
25e81f7
Compare
Collaborator
|
Thanks for contributing here. Please sign-off the commits in your PRs ( |
peppergrayxyz
force-pushed
the
make_cc
branch
from
25e81f7 to
2face26
Compare
Collaborator
|
The DCO CI check is still failing because:
You need to make the author of the commit match the Signed-off-by - I think this is a setting in GitHub, where it uses their generated noreply email address. |
mtjhrc
reviewed
Oct 21, 2025
Makefile
Outdated
| endif | ||
|
|
||
| OS = $(shell uname -s) | ||
| CC?= gcc |
Collaborator
There was a problem hiding this comment.
This doesn't really work, by default CC will be cc (at least on GNU Make) which means this assignment will never happen.
Contributor
Author
There was a problem hiding this comment.
removed the line!
peppergrayxyz
force-pushed
the
make_cc
branch
from
2face26 to
7e58579
Compare
mtjhrc
approved these changes
Nov 3, 2025
fix: containers#433 Signed-off-by: Pepper Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #433