test fails with arch_memory_regions missing argument #3 #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppergrayxyz
requested review from
MatiasVara,
jakecorrenti,
mtjhrc,
slp and
tylerfanelli
as code owners
arch_memory_regions needs 3 arguments, while it previously used to need 2. This was updated in arch/src/x86, but not in aarch64 and riscv64 Added a 3rd parameter 'None' where it was missing. Fixes: containers#435 Signed-off-by: Pepper Gray <[email protected]>
peppergrayxyz
force-pushed
the
arch_memory_regions
branch
from
89d72dd to
80ec415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arch_memory_regions needs 3 arguments, while it previously used to need 2. This was updated in arch/src/x86, but not in aarch64 and riscv64
Added a 3rd parameter 'None' where it was missing.
Fixes: #435