sources.py: fix unconditional return in map value clone #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the generated C code for cloning the object values of a mapStringObject, an 'if' statement checking for cloning failure was followed by an erroneous semicolon. This caused the 'if' to have an empty body, leading to the subsequent 'return NULL;' being executed unconditionally in the first iteration of the value-cloning loop if the map was not empty. Consequently, cloning a mapStringObject with one or more elements would always fail prematurely when this specific path for object-values was taken. Removing the semicolon makes the 'return NULL;' conditional upon actual cloning failure, as intended. Signed-off-by: Giuseppe Scrivano <[email protected]>
Member
Author
|
merging it as an obvious fix as it was reported by the compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the generated C code for cloning the object values of a mapStringObject, an 'if' statement checking for cloning failure was followed by an erroneous semicolon.
This caused the 'if' to have an empty body, leading to the subsequent 'return NULL;' being executed unconditionally in the first iteration of the value-cloning loop if the map was not empty. Consequently, cloning a mapStringObject with one or more elements would always fail prematurely when this specific path for object-values was taken.
Removing the semicolon makes the 'return NULL;' conditional upon actual cloning failure, as intended.