Skip to content

Conversation

@NicholasBHubbard
Copy link

This PR aims to solve issue #604.

I simply removed the dependency on python_version<'3.11' from the dependencies list. I determined that there was no need to change the minimum required version of tomli, due to tomli version 1.2.3 supporting any Python version greater or equal to 3.6. Here is a link to the pyproject.toml file for tomli version 1.2.3.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NicholasBHubbard
Once this PR has been reviewed and has the lgtm label, please assign mwhahaha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos
Copy link
Contributor

inknos commented Nov 11, 2025

Sorry for missing the point of the issue. I was tired and when I returned to it, I made a wrong evaluation.

The line "tomli>=1.2.3; python_version<'3.11'" is an environment marker that will imply that tomli would be installed if pyhton version is below 3.11. tomli is in python since 3.11

@inknos inknos closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants