Skip to content

Picking up incorrect project from GoCD #60

Description

@ipsi

Spotted an oddity with checkman today - it's reporting that one of our builds, redis-release has failed, but when we go to the build server, it's passed.

Looking at what GoCD returns, for our project I see the following:

<Project name="redis-release :: <...>" activity="Sleeping" lastBuildStatus="Success" lastBuildLabel="<...>" lastBuildTime="2015-06-13T12:09:59" webUrl="<...>" />

However, there is another project with the following:

<Project name="cf-redis-release :: <...>" activity="Sleeping" lastBuildStatus="Failure" lastBuildLabel="<...>" lastBuildTime="2015-06-13T12:55:58" webUrl="<...>">

Looking at cctray.check, I guess it's the following code causing the problem:

projects = @feed.xpath('//Project').select do |proj|
  proj.attr('name').downcase.include?(name.downcase)
end

Does that need to be include? or would start_with? or == be OK too?

May also be showing up because cf-redis-release has a more recent build than redis-release.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions